You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/15 10:12:18 UTC
[GitHub] [incubator-nuttx-apps] zhhyu7 opened a new pull request, #1269: Some WAPI changes
zhhyu7 opened a new pull request, #1269:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1269
## Summary
Fix coverity warning
Correct return value for scan case
Make the initial scan buffer configurable through Kconfig
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] zhhyu7 commented on a diff in pull request #1269: Some WAPI changes
Posted by GitBox <gi...@apache.org>.
zhhyu7 commented on code in PR #1269:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1269#discussion_r945614868
##########
wireless/wapi/src/wireless.c:
##########
@@ -1256,14 +1256,14 @@ int wapi_scan_stat(int sock, FAR const char *ifname)
return 1;
}
- printf("err[%d]: %s\n", errno, strerror(errno));
- }
- else
Review Comment:
> it's wrong?
change printf(error) to WAPI_IOCTL_STRERROR, and correct return value when ioctl return >=0.
Otherwise, when multiple threads switch, errno will be set to someone else's system call return code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a diff in pull request #1269: Some WAPI changes
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #1269:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1269#discussion_r945820905
##########
wireless/wapi/src/util.c:
##########
@@ -114,7 +114,7 @@ static FAR void *wapi_json_load(FAR const char *confname)
free(buf);
}
- if (fd > 0)
+ if (fd >= 0)
Review Comment:
I think this change matters only if we expect fd to be stdin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a diff in pull request #1269: Some WAPI changes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #1269:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1269#discussion_r945595369
##########
wireless/wapi/src/wireless.c:
##########
@@ -1256,14 +1256,14 @@ int wapi_scan_stat(int sock, FAR const char *ifname)
return 1;
}
- printf("err[%d]: %s\n", errno, strerror(errno));
- }
- else
Review Comment:
it's wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on pull request #1269: Some WAPI changes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #1269:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1269#issuecomment-1215077014
Let's ignore the Mix case warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1269: Some WAPI changes
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #1269:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org