You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/22 01:49:59 UTC

[GitHub] [apisix-dashboard] imjoey commented on a change in pull request #1344: fix: ignore the init_dir event when watching etcd events

imjoey commented on a change in pull request #1344:
URL: https://github.com/apache/apisix-dashboard/pull/1344#discussion_r562316242



##########
File path: api/internal/core/storage/etcd.go
##########
@@ -120,6 +126,8 @@ func (s *EtcdV3Storage) List(ctx context.Context, key string) ([]Keypair, error)
 		data := Keypair{
 			Key:   string(resp.Kvs[i].Key),
 			Value: string(resp.Kvs[i].Value),
+			// Mark the init_dir etcd event as skippable if value is init_dir
+			Skipped: string(resp.Kvs[i].Value) == SkippedValueEtcdInitDir,

Review comment:
       > APISIX may change it to `{}`, so I think we should deal with them in this PR if you have time for it. Thanks.
   
   @nic-chen thanks for the directions. I will set `{}` as skippable soon




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org