You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/24 01:35:37 UTC
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `17.27%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 34.12% -17.28%
+ Complexity 2668 1498 -1170
=============================================
Files 1275 565 -710
Lines 27659 14059 -13600
Branches 3003 1271 -1732
=============================================
- Hits 14215 4797 -9418
+ Misses 12801 8923 -3878
+ Partials 643 339 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [1004 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org