[GitHub] [pinot] snleee commented on a change in pull request #7424: Fix retention for cleaning up segment lineage

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #7424:
URL: https://github.com/apache/pinot/pull/7424#discussion_r707578739



##########
File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/retention/RetentionManager.java
##########
@@ -90,7 +90,16 @@ protected void postprocess() {
   }
 
   private void manageRetentionForTable(String tableNameWithType) {

Review comment:
       Let's do the following:
   
   ```
     protected void processTable(String tableNameWithType) {
       LOGGER.info("Start managing retention for table: {}", tableNameWithType);
       manageRetentionForTable(tableNameWithType);
       manageSegmentLineageCleanupForTable(tableNameWithType);
     }
   ```
   
   Let's do this 2 level at the top in the `processTable`. We can think of the retention and segment lineage cleanup as 2 separate steps.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org