You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/03/16 22:54:41 UTC

[jira] [Commented] (SAMZA-1149) upgrade mockito from 1.8.4 to 1.10.19

    [ https://issues.apache.org/jira/browse/SAMZA-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15929083#comment-15929083 ] 

ASF GitHub Bot commented on SAMZA-1149:
---------------------------------------

GitHub user fredji97 opened a pull request:

    https://github.com/apache/samza/pull/89

    SAMZA-1149: upgrade mockito from 1.8.4 to 1.10.19

    More details: https://issues.apache.org/jira/browse/SAMZA-1149
    Test: gradlew clean check successfully. All unit tests passed.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fredji97/samza mockitoUpgrade

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/samza/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit bfe0bb22339311e770dcf604e4c71c6554ab0837
Author: Fred Ji <fj...@linkedin.com>
Date:   2017-03-16T22:44:33Z

    upgrade mockito from 1.8.4 to 1.10.19

----


> upgrade mockito from 1.8.4 to 1.10.19
> -------------------------------------
>
>                 Key: SAMZA-1149
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1149
>             Project: Samza
>          Issue Type: Improvement
>            Reporter: Fred Ji
>
> The current version is 1.8.4 which is a version back to 2010. We would like to update it to the newer stable version. 
> The version we would like to use is 1.10.19, as this is a stable and newer version which can work with the staple and newer powermock which supports more powerful mocking such as for constructors and static methods, etc. But it requires a version match between powermock and mockito, see: 
> https://github.com/powermock/powermock/wiki/MockitoUsage#supported-versions
> Without the upgrade, if we include any modules from samza open source and also use powermock in our own code, and if we run unit test, we may see some exception due to version mismatch. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)