You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@thrift.apache.org by cleverchao <gi...@git.apache.org> on 2016/01/14 08:54:26 UTC

[GitHub] thrift pull request: Update NodeClient.js

GitHub user cleverchao opened a pull request:

    https://github.com/apache/thrift/pull/794

    Update NodeClient.js

    NodeClient.js has some mistakes, 
    When running this file, 
    "var ThriftTransports = require('thrift/transport');
    var ThriftProtocols = require('thrift/protocol');" 
    will raise an error because the path passed in require is not correct.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cleverchao/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/794.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #794
    
----
commit cb0d664582e879fbd0f3f12649a8c280c06aadf0
Author: cleverchao <cl...@163.com>
Date:   2016-01-14T07:51:34Z

    Update NodeClient.js

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #794: Update NodeClient.js

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/794


---

[GitHub] thrift issue #794: Update NodeClient.js

Posted by jeking3 <gi...@git.apache.org>.

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/794
  
    @jfarrell THRIFT-3904 and other, earlier commits already did the same thing, so this PR can be closed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Update NodeClient.js

Posted by nsuke <gi...@git.apache.org>.

Github user nsuke commented on the pull request:

    https://github.com/apache/thrift/pull/794#issuecomment-174192514
  
    @cleverchao thanks for the fix ! Could you create a JIRA issue for this ?
    http://thrift.apache.org/docs/HowToContribute


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---