[GitHub] nifi pull request #1138: NIFI-2778 added abilty to interrupt Lucene search

[mattyb149 <gi...@git.apache.org>]

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1138#discussion_r86852784
  
    --- Diff: nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/AsyncQuerySubmission.java ---
    @@ -82,4 +90,8 @@ public Query getQuery() {
         public StandardQueryResult getResult() {
             return queryResult;
         }
    +
    +    public void addQueryExecution(Future<?> execution) {
    --- End diff --
    
    Is this method only on AsyncQuerySubmission (versus the parent interface) because adding an execution only applies to async queries? I figure it is but wanted to make sure. If other implementations would benefit from this method, it might be better as an default interface method on the parent that throws a MethodNotSupported or something. But if it really only applies in this setting, I'm fine with that too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---