You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org> on 2009/03/12 06:36:50 UTC
[jira] Created: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
-------------------------------------------------------------------------------------------
Key: HADOOP-5471
URL: https://issues.apache.org/jira/browse/HADOOP-5471
Project: Hadoop Core
Issue Type: Bug
Components: mapred
Affects Versions: 0.19.1
Reporter: Amareshwari Sriramadasu
Fix For: 0.19.2
This happens in the following scenario:
If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681658#action_12681658 ]
Amareshwari Sriramadasu commented on HADOOP-5471:
-------------------------------------------------
Same patch applies to both branch 0.20 and branch 0.19
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-5471:
--------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Amareshwari!
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682547#action_12682547 ]
Amareshwari Sriramadasu commented on HADOOP-5471:
-------------------------------------------------
Test failure TestCapacityScheduler.testClusterBlockingForLackOfMemory is not related to the patch.
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5471:
--------------------------------------------
Attachment: patch-5471.txt
Patch with the fix
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-5471:
--------------------------------
Fix Version/s: (was: 0.19.2)
0.20.0
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.20.0
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682407#action_12682407 ]
Hadoop QA commented on HADOOP-5471:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12402246/patch-5471-1.txt
against trunk revision 754847.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/90/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/90/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-vesta.apache.org/90/console
This message is automatically generated.
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681702#action_12681702 ]
Hadoop QA commented on HADOOP-5471:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12402124/patch-5471.txt
against trunk revision 753113.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/60/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/60/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/60/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/60/console
This message is automatically generated.
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12682922#action_12682922 ]
Amareshwari Sriramadasu commented on HADOOP-5471:
-------------------------------------------------
Ran MRReliabilityTest. Also ran Sort benchmark with jvm-reuse on.
The patch has been tested for synclogs issue.
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5471:
--------------------------------------------
Status: Patch Available (was: Open)
test-patch result:
{noformat}
[exec]
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
[exec]
[exec] +1 Eclipse classpath. The patch retains Eclipse classpath integrity.
[exec]
[exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
[exec]
{noformat}
It is difficult to write testcase for this.
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12684002#action_12684002 ]
Hudson commented on HADOOP-5471:
--------------------------------
Integrated in Hadoop-trunk #785 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/785/])
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.20.0
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5471:
--------------------------------------------
Status: Patch Available (was: Open)
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5471:
--------------------------------------------
Status: Open (was: Patch Available)
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu reassigned HADOOP-5471:
-----------------------------------------------
Assignee: Amareshwari Sriramadasu
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5471) SyncLogs thread in Child.java would
update wrong file for a cleanup attempt, in some cases.
Posted by "Amareshwari Sriramadasu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Amareshwari Sriramadasu updated HADOOP-5471:
--------------------------------------------
Attachment: patch-5471-1.txt
Patch incorporating Devaraj's offline comments.
> SyncLogs thread in Child.java would update wrong file for a cleanup attempt, in some cases.
> -------------------------------------------------------------------------------------------
>
> Key: HADOOP-5471
> URL: https://issues.apache.org/jira/browse/HADOOP-5471
> Project: Hadoop Core
> Issue Type: Bug
> Components: mapred
> Affects Versions: 0.19.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.19.2
>
> Attachments: patch-5471-1.txt, patch-5471.txt
>
>
> This happens in the following scenario:
> If jvm is launched for a cleanup attempt and getTask has not returned yet. thus, isCleanup value is not obtained yet. But, the SyncLogs thread would do a syncLogs with wrong isCleanup value (i.e. with wrong index file).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.