You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by bu...@apache.org on 2006/03/26 21:29:28 UTC
DO NOT REPLY [Bug 39107] New: - autocomplete attribute
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
Summary: autocomplete attribute
Product: Struts
Version: 1.3.1
Platform: All
OS/Version: other
Status: NEW
Severity: enhancement
Priority: P5
Component: Taglibs
AssignedTo: dev@struts.apache.org
ReportedBy: melowe@mac.com
the non standard attribute autocomplete cannot be deactivated (i.e. autocomplete="off" ) without
subclassing the tag class itself and editing tld files, effectively forking from the struts code base.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From paul4christ79@yahoo.com 2006-03-26 23:13 -------
>From comment #5: What do you mean by "redisplay for password" ?
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From melowe@mac.com 2006-03-26 20:31 -------
Created an attachment (id=17986)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17986&action=view)
svn diff for BaseInputTag
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From melowe@mac.com 2006-03-26 23:23 -------
The attrinute of html:password that determines of existing values are redisplyed or not.. This is only used
for password but is defined in the superclass..
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From martinc@apache.org 2006-03-27 03:08 -------
(In reply to comment #8)
> Have you ever looked at all the nonstandard stuff it takes to use something
like the DOJO widgets?
This is probably in reference to the non-standard attribute approach to using
widgets in Dojo. (Note: not all caps; it's not an acronym. ;) I just wanted to
point out that there are two other approaches to widget usage, one using XML
namespaces and the other using CSS classes. (Yes, I know this is way off-topic
for this bug report, but hey, so was the original statement, and I wanted to
clarify. ;)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From craig.mcclanahan@sun.com 2006-03-27 02:49 -------
(In reply to comment #0)
> the non standard attribute autocomplete cannot be deactivated (i.e.
autocomplete="off" ) without
> subclassing the tag class itself and editing tld files, effectively forking
from the struts code base.
If I were going to take this approach, i'd do it with subclassing the
appropriate tag handler class (overriding the absolute minimum number of methods
possible), but creating a new TLD for "replacement" tags -- that would minimize
my pain of migrating to future versions.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From melowe@mac.com 2006-03-26 20:31 -------
Created an attachment (id=17987)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17987&action=view)
svn patch for FormTag
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From paul4christ79@yahoo.com 2006-03-26 21:31 -------
The problem with adding an autocomplete at the BaseInputTag level is that not
every subclass has a use for it. Radio boxes, check boxes, and textarea
components have no concept of being autocompleted. If possible, I would have
this limited only to the TextTag class.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From melowe@mac.com 2006-03-26 20:32 -------
Created an attachment (id=17988)
--> (http://issues.apache.org/bugzilla/attachment.cgi?id=17988&action=view)
svn diff for html tld
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From craig.mcclanahan@sun.com 2006-03-27 02:47 -------
(In reply to comment #5)
> With the tld between the tag class and the jsp it should prevent having
autocomplete in the super class
> pretty safe.. I did think about it, but in the case of redisplay for password,
this is also inherited from the
> superclass. I think the same is true of TextTag and the rows property.
Indeed, this philosophy is quite common across the tags ... attributes that are
defined by more than one of the individual tags are commonly declared in the
base tag class, but then omitted from the TLD if they are not relevant. So this
by itself is not a compelling reason to veto the proposed approach.
What's really sad is how the popularity of AJAX is totally screwing up people
who want to validate their pages. Have you ever looked at all the nonstandard
stuff it takes to use something like the DOJO widgets? :-(
However, given AJAX (and given that this particular case is pretty common), my
long standing resistance to non-XHTML attributes *might* be bendable a bit --
but only if we can make the tag handlers respect xhtml="true" on the top level
tag, and skip outputting anything for autocomplete in that case.
Would it be possible to construct a revised patch along those lines?
(By the way ... it is a lot easier to read a "unified diff" patch made with
something like "diff -u", and that's the preferred approach.)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From melowe@mac.com 2006-03-26 21:45 -------
With the tld between the tag class and the jsp it should prevent having autocomplete in the super class
pretty safe.. I did think about it, but in the case of redisplay for password, this is also inherited from the
superclass. I think the same is true of TextTag and the rows property.
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
DO NOT REPLY [Bug 39107] - autocomplete attribute
Posted by bu...@apache.org.
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=39107>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=39107
------- Additional Comments From melowe@mac.com 2006-03-27 08:18 -------
Craig I'll try and send in some revised patches this evening (GMT+1)..
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org