[jira] [Work logged] (ARTEMIS-2435) Configuration on device-block-size through CLI / broker.xml

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARTEMIS-2435?focusedWorklogId=286395&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-286395 ]

ASF GitHub Bot logged work on ARTEMIS-2435:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Aug/19 04:34
            Start Date: 01/Aug/19 04:34
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on pull request #2775:  ARTEMIS-2435 Configuration on device-block-size through CLI / broker.xml
URL: https://github.com/apache/activemq-artemis/pull/2775#discussion_r309519331
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/utils/XMLConfigurationUtil.java
 ##########
 @@ -44,7 +44,6 @@ public static final Double getDouble(final Element e,
          validator.validate(name, val);
          return val;
       } else {
-         validator.validate(name, def);
 
 Review comment:
   @michaelandrepearce well.. I don't see a point on that.. really.
   
   It's moot, it's dead code.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 286395)
    Time Spent: 2h 10m  (was: 2h)

> Configuration on device-block-size through CLI / broker.xml
> -----------------------------------------------------------
>
>                 Key: ARTEMIS-2435
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-2435
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.9.0
>            Reporter: clebert suconic
>            Assignee: clebert suconic
>            Priority: Major
>             Fix For: 2.10.0
>
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.14#76016)