You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Andreas Hartmann <an...@apache.org> on 2007/04/16 11:33:12 UTC

[1.4] config/publication.xconf vs. module.xml

Hi Lenya devs,

I just noticed that modules and publications use different
descriptor / configuration files.

Should we consolidate this?

If yes, which name/location do you prefer?

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: [1.4] config/publication.xconf vs. module.xml

Posted by Andreas Hartmann <an...@apache.org>.
Joern Nettingsmeier schrieb:

[...]

> while we're at it:
> 
> ./blog/config/ac/ac.xconf
> ./blog/config/notification/notification.xconf
> ./blog/config/publication.xconf
> ./default/config/ac/ac.xconf
> ./default/config/cocoon-xconf/instantiator.xconf
> ./default/config/lucene_index.xconf
> ./default/config/search/lucene-live.xconf
> ./default/config/publication.xconf
> ./default/modules/homepage/config/cocoon-xconf
> ./default/modules/homepage/config/cocoon-xconf/resource-type-homepage.xconf
> ./default/modules/defaultusecases/config/cocoon-xconf
> 
> ac.xconf and notification.xconf should be renamed,

+1

BTW, is "ac" obvious enough, or should we call it "access-control.xml"?

> with lucene i'm not
> sure - is this our code that reads the file or lucene's?

I guess it's ours, but I'm not sure.

> the use of .xconf vs. .xml is not really consistent anywhere... should
> .xconfs be only files that are treated as xpatchfiles (with "unless..."
> and friends),

IMO yes.

> or does it mean "xml configuration file". the latter would
> be ok for pretty much everything...
> 
> and one last thing:
> 
> does anybody care about src/pubs/*/publication-tests.xml ?

I don't. There should be a place for publication documentation, though,
and the test scenarios could go there. Maybe something for 1.4.1.


> it used to be aggregated with the old publication.xml file, but i did
> not rip it out lest somebody was using it for automated testing
> scripts... i'd like to get rid of it if nobody objects.

+1 to remove it.

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: [1.4] config/publication.xconf vs. module.xml

Posted by Joern Nettingsmeier <ne...@folkwang-hochschule.de>.
Andreas Hartmann wrote:
> Joern Nettingsmeier schrieb:
> 
> [...]
> 
>> i'd say most people use custom pubs and only a few people use custom
>> modules (and those can be expected to be clueful), so let's move
>> module.xml to <mymodule>/config/ rather than breaking publication.xconf
>> again.
> 
> Agreed.
> 
>> that said, another issues comes to mind, regarding .xml vs .xconf:
>> shouldn't xconf denote a patch file that is hacked into cocoon.xconf at
>> build time? if that is the case, maybe publication.xconf should be
>> publication.xml?
> 
> Yes, that occured to me too.
> 
> I'd say we do it properly and rename it to publication.xml.
> This would mean
> 
>   <pub>/config/publication.xml
>   <module>/config/module.xml
> 
> WDYT?

+1. although we probably owe our beta testers a beer after that :)

while we're at it:

./blog/config/ac/ac.xconf
./blog/config/notification/notification.xconf
./blog/config/publication.xconf
./default/config/ac/ac.xconf
./default/config/cocoon-xconf/instantiator.xconf
./default/config/lucene_index.xconf
./default/config/search/lucene-live.xconf
./default/config/publication.xconf
./default/modules/homepage/config/cocoon-xconf
./default/modules/homepage/config/cocoon-xconf/resource-type-homepage.xconf
./default/modules/defaultusecases/config/cocoon-xconf

ac.xconf and notification.xconf should be renamed, with lucene i'm not 
sure - is this our code that reads the file or lucene's?
the use of .xconf vs. .xml is not really consistent anywhere... should 
.xconfs be only files that are treated as xpatchfiles (with "unless..." 
and friends), or does it mean "xml configuration file". the latter would 
be ok for pretty much everything...

and one last thing:

does anybody care about src/pubs/*/publication-tests.xml ?
it used to be aggregated with the old publication.xml file, but i did 
not rip it out lest somebody was using it for automated testing 
scripts... i'd like to get rid of it if nobody objects.

regards,

jörn




-- 
jörn nettingsmeier

home://germany/45128 essen/lortzingstr. 11/
http://spunk.dnsalias.org
phone://+49/201/491621

Kurt is up in Heaven now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: [1.4] config/publication.xconf vs. module.xml

Posted by Andreas Hartmann <an...@apache.org>.
Joern Nettingsmeier schrieb:

[...]

> i'd say most people use custom pubs and only a few people use custom
> modules (and those can be expected to be clueful), so let's move
> module.xml to <mymodule>/config/ rather than breaking publication.xconf
> again.

Agreed.

> that said, another issues comes to mind, regarding .xml vs .xconf:
> shouldn't xconf denote a patch file that is hacked into cocoon.xconf at
> build time? if that is the case, maybe publication.xconf should be
> publication.xml?

Yes, that occured to me too.

I'd say we do it properly and rename it to publication.xml.
This would mean

  <pub>/config/publication.xml
  <module>/config/module.xml

WDYT?

-- Andreas


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org


Re: [1.4] config/publication.xconf vs. module.xml

Posted by Joern Nettingsmeier <ne...@folkwang-hochschule.de>.
Andreas Hartmann wrote:
> Hi Lenya devs,
> 
> I just noticed that modules and publications use different
> descriptor / configuration files.
> 
> Should we consolidate this?

maybe.
it might make sense to check whether module.xml is consistent with 
publication.xconf and make changes if necessary.

> If yes, which name/location do you prefer?

i'd say most people use custom pubs and only a few people use custom 
modules (and those can be expected to be clueful), so let's move 
module.xml to <mymodule>/config/ rather than breaking publication.xconf 
again.

that said, another issues comes to mind, regarding .xml vs .xconf: 
shouldn't xconf denote a patch file that is hacked into cocoon.xconf at 
build time? if that is the case, maybe publication.xconf should be 
publication.xml?



-- 
jörn nettingsmeier

home://germany/45128 essen/lortzingstr. 11/
http://spunk.dnsalias.org
phone://+49/201/491621

Kurt is up in Heaven now.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org