[jira] [Comment Edited] (BEAM-7810) Allow ValueProvider arguments to ReadFromDatastore

["Elias Djurfeldt (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-7810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17009731#comment-17009731 ] 

Elias Djurfeldt edited comment on BEAM-7810 at 1/7/20 1:51 PM:
---------------------------------------------------------------

Regarding the StackOverflow post. If I understand correctly, it's the Query namespace we're interested in adding support for ValueProviders, and not the ReadFromDatastore class, correct?

If that's the case, this should be quite a trivial fix not more difficult than adding this to the _`_to_client_query`_ method in the Query class.
{code:java}
if isinstance(self.namespace, ValueProvider):
    self.namespace = self.namespace.get()
{code}
and a test to accompany.

Sound reasonable? [~udim]


was (Author: eliasdjur):
Regarding the StackOverflow post. If I understand correctly, it's the Query namespace we're interested in adding support for ValueProviders, and not the ReadFromDatastore class, correct?

If that's the case, this should be quite a trivial fix not more difficult than 
{code:java}
if isinstance(self.namespace, ValueProvider):
    self.namespace = self.namespace.get()
{code}
and a test to accompany.

Sound reasonable? [~udim]

> Allow ValueProvider arguments to ReadFromDatastore
> --------------------------------------------------
>
>                 Key: BEAM-7810
>                 URL: https://issues.apache.org/jira/browse/BEAM-7810
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-py-gcp
>            Reporter: Udi Meiri
>            Priority: Minor
>
> From: https://stackoverflow.com/questions/56748893/trying-to-achieve-runtime-value-of-namespace-of-datastore-in-dataflow-template



--
This message was sent by Atlassian Jira
(v8.3.4#803005)