You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2009/09/29 15:25:47 UTC
svn commit: r819938 - in /spamassassin/trunk: sa-awl.raw xt/60_perlcritic.t
Author: jm
Date: Tue Sep 29 13:25:46 2009
New Revision: 819938
URL: http://svn.apache.org/viewvc?rev=819938&view=rev
Log:
add a Test::Perl::Critic release-test, with most criticisms turned off initially
Added:
spamassassin/trunk/xt/60_perlcritic.t (with props)
Modified:
spamassassin/trunk/sa-awl.raw
Modified: spamassassin/trunk/sa-awl.raw
URL: http://svn.apache.org/viewvc/spamassassin/trunk/sa-awl.raw?rev=819938&r1=819937&r2=819938&view=diff
==============================================================================
--- spamassassin/trunk/sa-awl.raw (original)
+++ spamassassin/trunk/sa-awl.raw Tue Sep 29 13:25:46 2009
@@ -1,15 +1,15 @@
#!/usr/bin/perl
+use strict;
+use warnings;
+use re 'taint';
+
my $PREFIX = '@@PREFIX@@'; # substituted at 'make' time
my $DEF_RULES_DIR = '@@DEF_RULES_DIR@@'; # substituted at 'make' time
my $LOCAL_RULES_DIR = '@@LOCAL_RULES_DIR@@'; # substituted at 'make' time
my $LOCAL_STATE_DIR = '@@LOCAL_STATE_DIR@@'; # substituted at 'make' time
use lib '@@INSTALLSITELIB@@'; # substituted at 'make' time
-use strict;
-use warnings;
-use re 'taint';
-
use Errno qw(EBADF);
use File::Spec;
use Config;
Added: spamassassin/trunk/xt/60_perlcritic.t
URL: http://svn.apache.org/viewvc/spamassassin/trunk/xt/60_perlcritic.t?rev=819938&view=auto
==============================================================================
--- spamassassin/trunk/xt/60_perlcritic.t (added)
+++ spamassassin/trunk/xt/60_perlcritic.t Tue Sep 29 13:25:46 2009
@@ -0,0 +1,39 @@
+#!/usr/bin/perl
+
+use strict;
+use warnings;
+use File::Spec;
+use Test::More;
+use English qw(-no_match_vars);
+
+BEGIN {
+ if (-d 'xt') { chdir 'xt'; }
+
+ if (-e 'test_dir') { # running from test directory, not ..
+ unshift(@INC, '../blib/lib');
+ unshift(@INC, '../lib');
+ }
+}
+
+eval { require Test::Perl::Critic; };
+
+if ( $EVAL_ERROR ) {
+ my $msg = 'Test::Perl::Critic required to criticise code';
+ plan( skip_all => $msg );
+}
+
+open RC, ">../t/log/perlcritic.rc" or die "cannot write t/log/perlcritic.rc";
+
+# we should remove some of these excludes if/when we feel like fixing 'em!
+print RC q{
+
+ severity = 5
+ verbose = 10
+ exclude = ValuesAndExpressions::ProhibitLeadingZeros InputOutput::ProhibitBarewordFileHandles InputOutput::ProhibitTwoArgOpen TestingAndDebugging::RequireUseStrict Subroutines::ProhibitExplicitReturnUndef Variables::RequireLexicalLoopIterators Subroutines::ProhibitSubroutinePrototypes ControlStructures::ProhibitMutatingListFunctions BuiltinFunctions::ProhibitStringyEval TestingAndDebugging::ProhibitNoStrict BuiltinFunctions::ProhibitSleepViaSelect BuiltinFunctions::RequireGlobFunction Variables::ProhibitConditionalDeclarations InputOutput::ProhibitInteractiveTest
+
+};
+close RC;
+
+Test::Perl::Critic->import( -profile => "../t/log/perlcritic.rc" );
+all_critic_ok("../blib");
+
Propchange: spamassassin/trunk/xt/60_perlcritic.t
------------------------------------------------------------------------------
svn:executable = *