You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by jk...@apache.org on 2006/02/22 22:48:43 UTC
svn commit: r379928 - in /jakarta/tapestry/branches/4.0: .classpath
framework/src/java/org/apache/tapestry/form/Form.js project.properties
status.xml
Author: jkuhnert
Date: Wed Feb 22 13:48:42 2006
New Revision: 379928
URL: http://svn.apache.org/viewcvs?rev=379928&view=rev
Log:
Applied form set_focus patch, wasn't able to apply new upload patch yet, too many weird error differences
Modified:
jakarta/tapestry/branches/4.0/.classpath
jakarta/tapestry/branches/4.0/framework/src/java/org/apache/tapestry/form/Form.js
jakarta/tapestry/branches/4.0/project.properties
jakarta/tapestry/branches/4.0/status.xml
Modified: jakarta/tapestry/branches/4.0/.classpath
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/branches/4.0/.classpath?rev=379928&r1=379927&r2=379928&view=diff
==============================================================================
Binary files - no diff available.
Modified: jakarta/tapestry/branches/4.0/framework/src/java/org/apache/tapestry/form/Form.js
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/branches/4.0/framework/src/java/org/apache/tapestry/form/Form.js?rev=379928&r1=379927&r2=379928&view=diff
==============================================================================
--- jakarta/tapestry/branches/4.0/framework/src/java/org/apache/tapestry/form/Form.js (original)
+++ jakarta/tapestry/branches/4.0/framework/src/java/org/apache/tapestry/form/Form.js Wed Feb 22 13:48:42 2006
@@ -85,14 +85,22 @@
Tapestry.set_focus = function (field)
{
- if (typeof field == "string")
- field = this.find(field);
-
- if (field.focus)
- field.focus();
-
- if (field.select)
- field.select();
+ if (typeof field == "string") {
+ field = this.find(field);
+
+ if (field) {
+ if (!field.disabled && field.clientWidth > 0) {
+ if (field.focus) {
+ field.focus();
+ }
+ if (field.isContentEditable || field.isContentEditable == null) {
+ if (field.select) {
+ field.select();
+ }
+ }
+ }
+ }
+ }
}
Tapestry.trim_field_value = function(fieldId)
Modified: jakarta/tapestry/branches/4.0/project.properties
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/branches/4.0/project.properties?rev=379928&r1=379927&r2=379928&view=diff
==============================================================================
--- jakarta/tapestry/branches/4.0/project.properties (original)
+++ jakarta/tapestry/branches/4.0/project.properties Wed Feb 22 13:48:42 2006
@@ -13,7 +13,7 @@
# limitations under the License.
project.name=jakarta-tapestry
-project.version=4.0
+project.version=4.0.1
dist.name=tapestry
Modified: jakarta/tapestry/branches/4.0/status.xml
URL: http://svn.apache.org/viewcvs/jakarta/tapestry/branches/4.0/status.xml?rev=379928&r1=379927&r2=379928&view=diff
==============================================================================
--- jakarta/tapestry/branches/4.0/status.xml (original)
+++ jakarta/tapestry/branches/4.0/status.xml Wed Feb 22 13:48:42 2006
@@ -24,6 +24,7 @@
<person name="Mind Bridge" id="MB"/>
<person name="Geoff Longman" id="GL"/>
<person name="Paul Ferraro" email="pmf8@columbia.edu" id="PF"/>
+ <person name="Jesse Kuhnert" email="jkuhnert@gmail.com" id="JK"/>
<!-- Add more people here -->
<!-- Retired: -->
<person name="Malcom Edgar" id="ME"/>
@@ -54,6 +55,12 @@
-->
</todo>
<changes>
+ <release version="4.0.1" date="unreleased" >
+ <action type="fix" dev="JK" fixes-bug="TAPESTRY-863" due-to="unknown contributor">
+ Form.set_focus() not compatible with some ie fields. Patch adds logic to check
+ more cross-browser friendly functions for setting focus.
+ </action>
+ </release>
<release version="4.0" date="Jan 6 2006">
<action type="update" dev="HLS">Add link to DeveloperWorks Tapestry article</action>
</release>
---------------------------------------------------------------------
To unsubscribe, e-mail: tapestry-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: tapestry-dev-help@jakarta.apache.org