You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/24 23:36:11 UTC
[GitHub] [flink] HuangZhenQiu opened a new pull request #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
HuangZhenQiu opened a new pull request #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947
## What is the purpose of the change
Consolidate executor related classes into the same module that underneath of org.apache.flink.client.deployment.exectuors.
## Brief change log
- Move classes into org.apache.flink.client.deployment.exectuors package.
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (yes / no / don't know)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578346458
<!--
Meta data
Hash:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5
-->
## CI report:
* 1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578892790
@HuangZhenQiu It does not seem to be a connection timeout. It seems like a compilation issue related to the changes of the PR https://travis-ci.com/flink-ci/flink/builds/146027147. Isn't this correct?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578346458
<!--
Meta data
Hash:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146027147 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
-->
## CI report:
* 1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 UNKNOWN
* d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146027147) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
HuangZhenQiu commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578870846
@kl0u
It is a connection timeout in WebFrontendITCase. I will take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578343749
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 (Fri Jan 24 23:38:01 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-15768).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
HuangZhenQiu commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578895426
@kl0u
Yes, you are right. There is also a compile error in kubernates executor. I already pushed a fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] HuangZhenQiu commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
HuangZhenQiu commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578344839
@kl0u
This change is to consolidate executor related classes in the same module. After this the cluster mode deployment classes within in org.apache.flink.client.deployment.deployers. How do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578346458
<!--
Meta data
Hash:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
-->
## CI report:
* 1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 UNKNOWN
* d62dc06fbd3e73c1769501bb4aeb02b0a517d18d UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578346458
<!--
Meta data
Hash:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146027147 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
Hash:86df7f4d0741306d10c4620a7d7de10f12369808 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:86df7f4d0741306d10c4620a7d7de10f12369808
-->
## CI report:
* 1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 UNKNOWN
* d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146027147) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617)
* 86df7f4d0741306d10c4620a7d7de10f12369808 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578346458
<!--
Meta data
Hash:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146027147 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
Hash:86df7f4d0741306d10c4620a7d7de10f12369808 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4633 TriggerType:PUSH TriggerID:86df7f4d0741306d10c4620a7d7de10f12369808
Hash:86df7f4d0741306d10c4620a7d7de10f12369808 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/146274968 TriggerType:PUSH TriggerID:86df7f4d0741306d10c4620a7d7de10f12369808
-->
## CI report:
* 1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 UNKNOWN
* d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146027147) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617)
* 86df7f4d0741306d10c4620a7d7de10f12369808 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/146274968) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4633)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-578346458
<!--
Meta data
Hash:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:1dcb22b1aa05daac90455fa4ddf293e4ae453ee5
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/146027147 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
Hash:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617 TriggerType:PUSH TriggerID:d62dc06fbd3e73c1769501bb4aeb02b0a517d18d
Hash:86df7f4d0741306d10c4620a7d7de10f12369808 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4633 TriggerType:PUSH TriggerID:86df7f4d0741306d10c4620a7d7de10f12369808
Hash:86df7f4d0741306d10c4620a7d7de10f12369808 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/146274968 TriggerType:PUSH TriggerID:86df7f4d0741306d10c4620a7d7de10f12369808
-->
## CI report:
* 1dcb22b1aa05daac90455fa4ddf293e4ae453ee5 UNKNOWN
* d62dc06fbd3e73c1769501bb4aeb02b0a517d18d Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/146027147) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4617)
* 86df7f4d0741306d10c4620a7d7de10f12369808 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/146274968) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4633)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
kl0u commented on issue #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947#issuecomment-579690034
Merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] kl0u closed pull request #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #10947: [FLINK-15768] [Client/Job Submission] Consolidate executor related cl…
URL: https://github.com/apache/flink/pull/10947
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services