You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by "shibd (via GitHub)" <gi...@apache.org> on 2023/03/31 02:13:42 UTC

[GitHub] [pulsar-client-cpp] shibd opened a new pull request, #240: Fix ack non-persistent topic will be blocked.

shibd opened a new pull request, #240:
URL: https://github.com/apache/pulsar-client-cpp/pull/240

   ### Motivation
   
   #232 change interface of `AckGroupingTracker` default impl. 
   
   When ack to the non-persistent topic, callback never be called.
   
   ### Modifications
   
   - Default call to callback.
   
   ### Verifying this change
   - Add `testAckNotPersistentTopic` to cover it.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
   
   - [x] `doc-not-needed` 
   (Please explain why)
   
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar-client-cpp] shibd merged pull request #240: Fix ack non-persistent topic will be blocked.

Posted by "shibd (via GitHub)" <gi...@apache.org>.

shibd merged PR #240:
URL: https://github.com/apache/pulsar-client-cpp/pull/240


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org