You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "mike-lmctl (via GitHub)" <gi...@apache.org> on 2026/05/07 09:07:21 UTC
[PR] Fix JWT user context for list API filters [superset]
mike-lmctl opened a new pull request, #39946:
URL: https://github.com/apache/superset/pull/39946
Fixes #39834.
Bearer-authenticated API requests can pass FAB authorization while Superset's
database and dataset list filters still evaluate permissions with an anonymous
`g.user`. This resolves the JWT user before those permission filters run, so the
list results match the authenticated user instead of falling back to public
access.
I added focused regression coverage for database and dataset list requests using
a fresh client with only an `Authorization: Bearer` header. I also covered an
invalid Bearer token so it returns 401 instead of an internal error.
Tests run:
- Targeted integration tests for JWT database and dataset list requests, invalid
Bearer handling, and the login endpoint
- `uvx ruff check` on the changed files
- `git diff --check`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix JWT user context for list API filters [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-4878296861
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39946?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `11.76471%` with `15 lines` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 55.86%. Comparing base ([`9f8ff1e`](https://app.codecov.io/gh/apache/superset/commit/9f8ff1e87f422e6427705a383d19f78f901b893f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3442e8e`](https://app.codecov.io/gh/apache/superset/commit/3442e8e5ba75115cac524112452e85eddc118496?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/39946?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/39946?src=pr&el=tree&filepath=superset%2Fsecurity%2Fmanager.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | 11.76% | [14 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/superset/pull/39946?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #39946 +/- ##
==========================================
- Coverage 64.63% 55.86% -8.77%
==========================================
Files 2685 2685
Lines 148530 148546 +16
Branches 34267 34271 +4
==========================================
- Hits 96005 82989 -13016
- Misses 50769 64805 +14036
+ Partials 1756 752 -1004
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.72% <11.76%> (?)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `40.72% <11.76%> (-18.49%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/39946/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/39946?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: hydrate JWT user before list API filters [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-5099477043
Thanks for reworking this into `request_loader()`, that's the right spot for it. But `test-mysql`/`test-postgres`/`test-sqlite` are failing on your own new tests, not something unrelated.
`test_get_dataset_list_with_jwt_auth` passes `owners=` to `insert_dataset()`, which doesn't take that kwarg (tests/integration_tests/datasets/api_tests.py). And both invalid-token tests assert a 401 but flask-jwt-extended is actually returning 422 for a malformed token, so either the assertion or the handling in `request_loader()` needs to change.
Can you fix those up and get CI green? Also worth resolving Bito's guest-token-fallback thread while you're in there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix JWT user context for list API filters [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #39946:
URL: https://github.com/apache/superset/pull/39946#discussion_r3521583363
##########
tests/integration_tests/base_tests.py:
##########
@@ -295,6 +295,16 @@ def get_or_create(self, cls, criteria, **kwargs):
def login(self, username, password=DEFAULT_PASSWORD):
return login(self.client, username, password)
+ def get_bearer_auth_header(
+ self, username=ADMIN_USERNAME, password=DEFAULT_PASSWORD
+ ):
+ response = self.client.post(
+ "/api/v1/security/login",
+ json={"username": username, "password": password, "provider": "db"},
+ )
+ assert response.status_code == 200
+ return {"Authorization": f"Bearer {response.json['access_token']}"}
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing docstring and type hints</b></div>
<div id="fix">
The new `get_bearer_auth_header` method lacks both a docstring and type annotations, which violates multiple BITO.md rules (12101, 12147, 12490, 12497, 12517, 12587, 12658) and the project's Python typing standards from dev-standard.mdc/AGENTS.md requiring all new Python code to have type hints.
</div>
</div>
<small><i>Code Review Run #e9ae1b</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: hydrate JWT user before list API filters [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #39946:
URL: https://github.com/apache/superset/pull/39946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix JWT user context for list API filters [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-4748918715
Thanks @mike-lmctl, this nails the right bug and the repro in #39834 is super clear.
Two things before this can move, though. It's conflicting with current `master` now and needs a rebase.
The part I want to think through: `can_access` is about the hottest authz primitive we have (~44 call sites), and putting `verify_jwt_in_request()` plus a `g.user` write inside it means every Bearer request that lands there with an anonymous `g.user` re-verifies the token and mutates request state as a side effect. That feels like a lot of surface for a list-filter fix. Could we hydrate the JWT user once earlier in the request lifecycle (a `before_request`/auth hook, closer to where FAB resets `g.user`) rather than from inside the permission check? Curious whether you tried that route and hit a wall. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: hydrate JWT user before list API filters [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-5080192982
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 19f584665954a1678da9882dcba53c896d98a32a |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a6509c2a799d90008983c90 |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-39946--superset-docs-preview.netlify.app](https://deploy-preview-39946--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcpBDkAwEADAv-zZJhuirB94RrUVldKmVhDxd73NYV5IOW5JYACoYMp6N0vx7G9cL0GdPAZ_CJ6Hy2jiLu6WEq1LIT6jLVVp1RKbWnfMlomo574xTPD9) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-39946--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: hydrate JWT user before list API filters [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on code in PR #39946:
URL: https://github.com/apache/superset/pull/39946#discussion_r3753345493
##########
tests/integration_tests/base_tests.py:
##########
@@ -295,6 +295,16 @@ def get_or_create(self, cls, criteria, **kwargs):
def login(self, username, password=DEFAULT_PASSWORD):
return login(self.client, username, password)
+ def get_bearer_auth_header(
+ self, username=ADMIN_USERNAME, password=DEFAULT_PASSWORD
+ ):
+ response = self.client.post(
+ "/api/v1/security/login",
+ json={"username": username, "password": password, "provider": "db"},
+ )
+ assert response.status_code == 200
+ return {"Authorization": f"Bearer {response.json['access_token']}"}
Review Comment:
This is stale relative to the current diff — `get_bearer_auth_header` already has both a docstring and full type hints (`username: str = ADMIN_USERNAME, password: str = DEFAULT_PASSWORD) -> dict[str, str]`, with `"""Return an Authorization header with a login access token."""` as the docstring. Resolving.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix JWT user context for list API filters [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-4395730044
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: hydrate JWT user before list API filters [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-5080796941
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix JWT user context for list API filters [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-4878871256
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: hydrate JWT user before list API filters [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #39946:
URL: https://github.com/apache/superset/pull/39946#discussion_r3753346653
##########
tests/integration_tests/base_tests.py:
##########
@@ -295,6 +295,16 @@ def get_or_create(self, cls, criteria, **kwargs):
def login(self, username, password=DEFAULT_PASSWORD):
return login(self.client, username, password)
+ def get_bearer_auth_header(
+ self, username=ADMIN_USERNAME, password=DEFAULT_PASSWORD
+ ):
+ response = self.client.post(
+ "/api/v1/security/login",
+ json={"username": username, "password": password, "provider": "db"},
+ )
+ assert response.status_code == 200
+ return {"Authorization": f"Bearer {response.json['access_token']}"}
Review Comment:
<!-- Bito Reply -->
The suggestion is no longer applicable as the code has been updated to include the necessary docstring and type hints. You can safely resolve this thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix JWT user context for list API filters [superset]
Posted by "mike-lmctl (via GitHub)" <gi...@apache.org>.
mike-lmctl commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-4877934988
Thanks @rusackas, that concern makes sense. I rebased this onto current \ and reworked the fix so JWT hydration no longer happens inside \ or \.
The updated patch resolves Bearer JWT users once in \, before the database/dataset list filters evaluate permissions. Embedded guest tokens keep precedence there, and invalid guest tokens now fail closed rather than falling through to Bearer auth.
I also kept the database/dataset Bearer-token regression coverage and added invalid-token cases, plus a unit regression for the guest-token/Bearer precedence edge case.
Local verification I could run here:
- \E902 No such file or directory (os error 2)
--> tests/unit_tests/security/manager_test.py\:1:1
Found 1 error.
- \
- \
I could not run the focused pytest set in this local workspace because the available interpreter is missing Flask, so I’ll watch the PR checks now that the branch is updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: hydrate JWT user before list API filters [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39946:
URL: https://github.com/apache/superset/pull/39946#issuecomment-5186786558
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
<details>
<summary>
Bito Usage Guide
</summary>
**Commands**
Type the following command in the pull request comment and save the comment.
- `/review` - Manually triggers a full AI review.
- `/pause` - Pauses automatic reviews on this pull request.
- `/resume` - Resumes automatic reviews.
- `/resolve` - Marks all Bito-posted review comments as resolved.
- `/abort` - Cancels all in-progress reviews.
Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
**Configuration**
This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
**Documentation & Help**
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
- <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org