You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Rob Godfrey <ro...@gmail.com> on 2012/01/25 15:46:35 UTC
Re: svn commit: r1235255 - /qpid/trunk/qpid/python/qpid/connection.py
After this commit we are seeing failure of the Python tests against both
the C++ Broker (https://builds.apache.org/job/Qpid-Python-Cpp-Test/77/) and
the Java Broker in the CI environment.
The tests failing are
- qpid.tests.connection.ConnectionTest.testCloseGet<https://builds.apache.org/job/Qpid-Python-Cpp-Test/77/testReport/junit/qpid.tests.connection/ConnectionTest/testCloseGet/>
- qpid.tests.connection.ConnectionTest.testCloseListen<https://builds.apache.org/job/Qpid-Python-Cpp-Test/77/testReport/junit/qpid.tests.connection/ConnectionTest/testCloseListen/>
Cheers,
Rob
On 24 January 2012 15:06, <mg...@apache.org> wrote:
> Author: mgoulish
> Date: Tue Jan 24 14:06:06 2012
> New Revision: 1235255
>
> URL: http://svn.apache.org/viewvc?rev=1235255&view=rev
> Log:
> qpid-3778
> see comment in code.
> this was causing a "connection aborted" failure when qpid-stat was
> connected
> through MD5, and there were several qpid-tools also connected, not in any
> special way, and not doing anything.
>
> Modified:
> qpid/trunk/qpid/python/qpid/connection.py
>
> Modified: qpid/trunk/qpid/python/qpid/connection.py
> URL:
> http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid/connection.py?rev=1235255&r1=1235254&r2=1235255&view=diff
>
> ==============================================================================
> --- qpid/trunk/qpid/python/qpid/connection.py (original)
> +++ qpid/trunk/qpid/python/qpid/connection.py Tue Jan 24 14:06:06 2012
> @@ -161,9 +161,12 @@ class Connection(Framer):
> data = self.sock.recv(64*1024)
> if self.security_layer_rx and data:
> status, data = self.security_layer_rx.decode(data)
> - if not data:
> - self.detach_all()
> - break
> + # zero-length data is OK, as long as return code is good.
> + # when that happens, just keep trying. the sasl library
> + # will send us data eventually. ( or an error code. )
> + if not status:
> + self.detach_all()
> + break
> except socket.timeout:
> if self.aborted():
> self.close_code = (None, "connection timed out")
>
>
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:commits-subscribe@qpid.apache.org
>
>
Re: svn commit: r1235255 -
/qpid/trunk/qpid/python/qpid/connection.py
Posted by mick <mg...@redhat.com>.
sorry about that! looking into it now...
On Wed, 2012-01-25 at 15:46 +0100, Rob Godfrey wrote:
> After this commit we are seeing failure of the Python tests against both
> the C++ Broker (https://builds.apache.org/job/Qpid-Python-Cpp-Test/77/) and
> the Java Broker in the CI environment.
>
> The tests failing are
>
>
> - qpid.tests.connection.ConnectionTest.testCloseGet<https://builds.apache.org/job/Qpid-Python-Cpp-Test/77/testReport/junit/qpid.tests.connection/ConnectionTest/testCloseGet/>
> - qpid.tests.connection.ConnectionTest.testCloseListen<https://builds.apache.org/job/Qpid-Python-Cpp-Test/77/testReport/junit/qpid.tests.connection/ConnectionTest/testCloseListen/>
>
>
> Cheers,
> Rob
>
> On 24 January 2012 15:06, <mg...@apache.org> wrote:
>
> > Author: mgoulish
> > Date: Tue Jan 24 14:06:06 2012
> > New Revision: 1235255
> >
> > URL: http://svn.apache.org/viewvc?rev=1235255&view=rev
> > Log:
> > qpid-3778
> > see comment in code.
> > this was causing a "connection aborted" failure when qpid-stat was
> > connected
> > through MD5, and there were several qpid-tools also connected, not in any
> > special way, and not doing anything.
> >
> > Modified:
> > qpid/trunk/qpid/python/qpid/connection.py
> >
> > Modified: qpid/trunk/qpid/python/qpid/connection.py
> > URL:
> > http://svn.apache.org/viewvc/qpid/trunk/qpid/python/qpid/connection.py?rev=1235255&r1=1235254&r2=1235255&view=diff
> >
> > ==============================================================================
> > --- qpid/trunk/qpid/python/qpid/connection.py (original)
> > +++ qpid/trunk/qpid/python/qpid/connection.py Tue Jan 24 14:06:06 2012
> > @@ -161,9 +161,12 @@ class Connection(Framer):
> > data = self.sock.recv(64*1024)
> > if self.security_layer_rx and data:
> > status, data = self.security_layer_rx.decode(data)
> > - if not data:
> > - self.detach_all()
> > - break
> > + # zero-length data is OK, as long as return code is good.
> > + # when that happens, just keep trying. the sasl library
> > + # will send us data eventually. ( or an error code. )
> > + if not status:
> > + self.detach_all()
> > + break
> > except socket.timeout:
> > if self.aborted():
> > self.close_code = (None, "connection timed out")
> >
> >
> >
> > ---------------------------------------------------------------------
> > Apache Qpid - AMQP Messaging Implementation
> > Project: http://qpid.apache.org
> > Use/Interact: mailto:commits-subscribe@qpid.apache.org
> >
> >
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org