You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2020/08/25 22:30:49 UTC
[GitHub] [sling-org-apache-sling-starter] cmrockwell opened a new pull request #13: SLING-9695 Added options for datastore
cmrockwell opened a new pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13
Added options for datastore sling.run.mode.install.options, which could be combined with either oak_mongo or oak_tar. Updated Readme.md describing install options.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell edited a comment on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell edited a comment on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-680933657
@rombert Thanks for the feedback. Launching the instance as you suggest with a series of feature.json is a bit cumbersome as compared to the prior way (`java -jar org.apache.sling.starter-12-SNAPSHOT.jar`). I worry about typing it wrong or missing one or more important features; thus introducing bugs. Is there is a maven command (and pom config) to generate Feature Archive as a Jar file containing a predefined set of features (oak_tar, file datastore, composum, web console) that could be started without all the -f args?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682179727
Oh, an according to https://github.com/apache/sling-org-apache-sling-feature-launcher/blob/7aa00ee307f5b3452b6a1cc3f3e2959251a3d6ca/src/main/java/org/apache/sling/feature/launcher/impl/Bootstrap.java#L73 , a variable named `sling.home` should be supported, please file a bug.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-681076010
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [
0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-687264251
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [
0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=duplicated_lines_density&view=list) No Duplication information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682058124
One note. The path was hard coded as shown below
` "org.apache.jackrabbit.oak.plugins.blob.datastore.FileDataStore": {
"minRecordLength":4096,
"path":"sling/repository/datastore",
"cacheSizeInMB":128
}`
boot.json uses a variable ${sling.home} but when I tried using that for the datastore `path` it created a directory with that variable name (not the value). It created a directory literally called "${sling.home}"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-737379550
This pull request has expired.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
rombert commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682178850
Thanks for the update. I am not sure we should be generating so many aggregates ... we have a large number of combinations of NodeStores and DataStores, e.g.
- SegmentNodeStore
- DocumentNodeStore + MongoDB
- DocumentNodeStore + RDB (Postgres?)
- No BlobStore
- FileBlobStore
- MongoBlobStore
- RDBBlobStore
(etc, etc)
The idea behind having an additional file which configures just the DataStore was to combine one NodeStore with one DataStore, instead of 'hardcoding' combinations. Additionally, if we generate `far` files as well, we greatly increase the storage needed. But I should think about this some more tomorrow, it's a bit late over here right now :-)
About the hardcoded path, I think you can work around it by defining another variable
```
"variables": {
"repository.home": "${sling.home}/repository"
}
```
And then referencing `${repository.home}` in the configuration values.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell edited a comment on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell edited a comment on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682735735
I don't necessarily see a problem adding any or all of those aggregates @rombert IMO it's nice to have working options and examples. Nevertheless ticket SLING-9695 requests file datastore as default, so I went ahead and removed that oak_tar_fds aggregate and configured file datastore by default. Many application developers would want the performance boost that comes with saving binaries outside of the segment (or document) store, so one of the example aggregates should demonstrate that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682735735
I don't necessarily see a problem adding any or all of aggregates @rombert IMO it's nice to have working options and examples. Nevertheless ticket SLING-9695 requests file datastore as default, so I went ahead and removed that oak_tar_fds aggregate and configured file datastore by default. Many application developers would want the performance boost that comes with saving binaries outside of the segment (or document) store, so one of the example aggregates should demonstrate that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682726733
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [
0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=duplicated_lines_density&view=list) No Duplication information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682726733
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [
0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=duplicated_lines_density&view=list) No Duplication information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-681152224
Update: I updated the pull request resolving the PM/FM conflict and created an aggregate feature file (oak_tar_fds.json) This satisfies my requirement for keeping the launch command relatively simple. Also tweaked the README to make it even more useful.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-681076010
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [
0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3.png' alt='0.0%' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=new_duplicated_lines_density&view=list)
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682725340
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [
0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=duplicated_lines_density&view=list) No Duplication information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] rombert commented on a change in pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
rombert commented on a change in pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#discussion_r485013649
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
Review comment:
Any particular reason to add this step? I think it's simpler to not copy it, but use it directly in its configured location.
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
+3) Copy either the feature archive (*.far) or individual set of feature.json files to the project folder
- mvn clean install
-
-in the current directory.
-2) Start Sling backed by an Oak SegmentStore with
+Example 1: Start an instance using the launcher specifying a feature archive (.far)
+This example uses the aggregate `oak_tar_far` as defined in the pom.xml
- java -jar target/dependency/org.apache.sling.feature.launcher.jar -f target/slingfeature-tmp/feature-oak_tar.json
-
-3) Browse Sling in:
+ java -jar org.apache.sling.feature.launcher.jar -f org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far
+
+Example 2: Start an instance using the launcher specifying an aggregate feature file.
+This example uses the aggregate `feature-oak_tar.json` as defined in the pom.xml
+
+ java -jar org.apache.sling.feature.launcher.jar -f feature-oak_tar.json
Review comment:
You are missing the `target/slingfeature-tmp` prefix here.
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
+3) Copy either the feature archive (*.far) or individual set of feature.json files to the project folder
- mvn clean install
-
-in the current directory.
-2) Start Sling backed by an Oak SegmentStore with
+Example 1: Start an instance using the launcher specifying a feature archive (.far)
+This example uses the aggregate `oak_tar_far` as defined in the pom.xml
- java -jar target/dependency/org.apache.sling.feature.launcher.jar -f target/slingfeature-tmp/feature-oak_tar.json
-
-3) Browse Sling in:
+ java -jar org.apache.sling.feature.launcher.jar -f org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far
Review comment:
You are missing the `target/slingfeature-tmp` prefix here.
##########
File path: README.md
##########
@@ -20,17 +20,26 @@ See [Releasing a new version of the Sling starter](https://cwiki.apache.org/conf
directory. It is advisable to use a work directory outside of the
project directory.
-1) Build the Sling Starter using
+1) Build the Sling Starter using `mvn clean install` in the current directory.
+2) Copy the launch to project directory `cp target/dependency/org.apache.sling.feature.launcher.jar $path-to-project`
+3) Copy either the feature archive (*.far) or individual set of feature.json files to the project folder
- mvn clean install
-
-in the current directory.
-2) Start Sling backed by an Oak SegmentStore with
+Example 1: Start an instance using the launcher specifying a feature archive (.far)
+This example uses the aggregate `oak_tar_far` as defined in the pom.xml
- java -jar target/dependency/org.apache.sling.feature.launcher.jar -f target/slingfeature-tmp/feature-oak_tar.json
-
-3) Browse Sling in:
+ java -jar org.apache.sling.feature.launcher.jar -f org.apache.sling.starter-12-SNAPSHOT-oak_tar_far.far
+
+Example 2: Start an instance using the launcher specifying an aggregate feature file.
+This example uses the aggregate `feature-oak_tar.json` as defined in the pom.xml
+
+ java -jar org.apache.sling.feature.launcher.jar -f feature-oak_tar.json
+
+Example 3: Start an instance using the launcher specifying a set feature files.
+
+ java -jar org.apache.sling.feature.launcher.jar -f feature-base.json,feature-boot.json,....
Review comment:
Perhaps it would be better to point to the feature model launcher documentation instead?
##########
File path: pom.xml
##########
@@ -127,7 +127,7 @@
<classifier>oak_mongo_far</classifier>
<includeClassifier>oak_mongo</includeClassifier>
</archive>
- </archives>
Review comment:
Can you please drop these whitespace-only changes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] sonarcloud[bot] removed a comment on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-682725340
Kudos, SonarCloud Quality Gate passed!
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug.png' alt='Bug' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=BUG)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability.png' alt='Vulnerability' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=VULNERABILITY) (and [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot.png' alt='Security Hotspot' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) [
0 Security Hotspots](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=SECURITY_HOTSPOT) to review)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell.png' alt='Code Smell' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A.png' alt='A' width='16' height='16' />](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-starter&pullRequest=13&resolved=false&types=CODE_SMELL)
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/NoCoverageInfo.png' alt='No Coverage information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13) No Coverage information
[<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/NoDuplicationInfo.png' alt='No Duplication information' width='16' height='16' />](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-starter&pullRequest=13&metric=duplicated_lines_density&view=list) No Duplication information
<img src='https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/message_warning.png' alt='warning' width='16' height='16' /> The version of Java (1.8.0_252) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more [here](https://sonarcloud.io/documentation/upcoming/)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell commented on pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell commented on pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13#issuecomment-680933657
@rombert Thanks for the feedback. Launching the instance as you suggest with a series of feature.json is a bit cumbersome as compared to the prior way (`java -jar org.apache.sling.starter-12-SNAPSHOT.jar`). I worry about typing it wrong or missing one or more important features; this introducing bugs. Is there is a maven command (and pom config) to generate Feature Archive as a Jar file containing a predefined set of features (oak_tar, file datastore, composum, web console) that could be started without all the -f args?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [sling-org-apache-sling-starter] cmrockwell closed pull request #13: SLING-9695 Added options for datastore
Posted by GitBox <gi...@apache.org>.
cmrockwell closed pull request #13:
URL: https://github.com/apache/sling-org-apache-sling-starter/pull/13
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org