You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by dg...@hyperreal.org on 1998/01/21 23:22:10 UTC
cvs commit: apachen/src/support suexec.c
dgaudet 98/01/21 14:22:10
Modified: src CHANGES
src/support suexec.c
Log:
add errno to suexec error messages
PR: 1543
Submitted by: Marc Slemko
Reviewed by: Dean Gaudet, Martin Kraemer, Jim Jagielski
Revision Changes Path
1.581 +2 -0 apachen/src/CHANGES
Index: CHANGES
===================================================================
RCS file: /export/home/cvs/apachen/src/CHANGES,v
retrieving revision 1.580
retrieving revision 1.581
diff -u -r1.580 -r1.581
--- CHANGES 1998/01/21 22:18:58 1.580
+++ CHANGES 1998/01/21 22:22:07 1.581
@@ -1,5 +1,7 @@
Changes with Apache 1.3b4
+ *) suexec errors now include the errno/description. [Marc Slemko] PR#1543
+
*) PORT: OSF/1 now uses USE_FLOCK_SERIALIZED_ACCEPT to solve PR#467.
The choice of flock vs. fcntl was made based on timings which showed that
even on non-NFS, non-exported filesystems fcntl() was an order of
1.32 +11 -9 apachen/src/support/suexec.c
Index: suexec.c
===================================================================
RCS file: /export/home/cvs/apachen/src/support/suexec.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -r1.31 -r1.32
--- suexec.c 1998/01/07 16:47:14 1.31
+++ suexec.c 1998/01/21 22:22:09 1.32
@@ -68,19 +68,21 @@
*/
-#include "suexec.h"
-
#include <sys/param.h>
-#include <stdlib.h>
-#include <unistd.h>
+#include <sys/stat.h>
#include <sys/types.h>
-#include <stdio.h>
+
+#include <errno.h>
+#include <grp.h>
+#include <pwd.h>
#include <stdarg.h>
+#include <stdio.h>
+#include <stdlib.h>
#include <string.h>
-#include <pwd.h>
-#include <grp.h>
#include <time.h>
-#include <sys/stat.h>
+#include <unistd.h>
+
+#include "suexec.h"
/*
***********************************************************************
@@ -499,6 +501,6 @@
*
* Oh well, log the failure and error out.
*/
- log_err("exec failed (%s)\n", cmd);
+ log_err("(%d)%s: exec failed (%s)\n", errno, strerror(errno), cmd);
exit(255);
}