You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/29 20:44:57 UTC
[GitHub] [nifi] greyp9 opened a new pull request, #6731: NIFI-10901 - PublishKafka headers not sent in ProducerRecord
greyp9 opened a new pull request, #6731:
URL: https://github.com/apache/nifi/pull/6731
### Issue Tracking
- [x] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [x] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [x] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [x] Pull Request based on current revision of the `main` branch
- [x] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 merged pull request #6731: NIFI-10901 - PublishKafka headers not sent in ProducerRecord
Posted by GitBox <gi...@apache.org>.
markap14 merged PR #6731:
URL: https://github.com/apache/nifi/pull/6731
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #6731: NIFI-10901 - PublishKafka headers not sent in ProducerRecord
Posted by GitBox <gi...@apache.org>.
greyp9 commented on code in PR #6731:
URL: https://github.com/apache/nifi/pull/6731#discussion_r1035267777
##########
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/PublisherLease.java:
##########
@@ -431,7 +431,8 @@ private void addHeaders(final FlowFile flowFile, final Map<String, String> addit
}
protected void publish(final FlowFile flowFile, final byte[] messageKey, final byte[] messageContent, final String topic, final InFlightMessageTracker tracker, final Integer partition) {
- publish(flowFile, Collections.emptyList(), messageKey, messageContent, topic, tracker, partition);
Review Comment:
the defect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #6731: NIFI-10901 - PublishKafka headers not sent in ProducerRecord
Posted by GitBox <gi...@apache.org>.
greyp9 commented on code in PR #6731:
URL: https://github.com/apache/nifi/pull/6731#discussion_r1035269962
##########
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/test/resources/Publish/parameterized/flowfileInput1.json:
##########
@@ -0,0 +1,8 @@
+{
Review Comment:
some test inputs from the doc for `PublishKafka`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] markap14 commented on pull request #6731: NIFI-10901 - PublishKafka headers not sent in ProducerRecord
Posted by GitBox <gi...@apache.org>.
markap14 commented on PR #6731:
URL: https://github.com/apache/nifi/pull/6731#issuecomment-1332565542
Thanks @greyp9 . Code changes look good. Was able to test & verify everything manually. Build looks good. +1 merged to main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] greyp9 commented on a diff in pull request #6731: NIFI-10901 - PublishKafka headers not sent in ProducerRecord
Posted by GitBox <gi...@apache.org>.
greyp9 commented on code in PR #6731:
URL: https://github.com/apache/nifi/pull/6731#discussion_r1035269476
##########
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/test/java/org/apache/nifi/processors/kafka/pubsub/TestPublishKafkaMockParameterized.java:
##########
@@ -31,17 +31,12 @@
import org.apache.kafka.clients.producer.ProducerRecord;
import org.apache.kafka.clients.producer.RecordMetadata;
import org.apache.kafka.common.TopicPartition;
Review Comment:
The previous naming was incorrect. `TestPublishKafkaMockParameterized` was testing `PublishKafkaRecord`. I copied this class to `TestPublishKafkaRecordMockParameterized`, and modified this class to test `PublishKafka`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org