You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2012/07/01 09:01:44 UTC
[jira] [Created] (CASSANDRA-4399) use data size ratio in liveRatio
instead of live size : serialized throughput
Jonathan Ellis created CASSANDRA-4399:
-----------------------------------------
Summary: use data size ratio in liveRatio instead of live size : serialized throughput
Key: CASSANDRA-4399
URL: https://issues.apache.org/jira/browse/CASSANDRA-4399
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.8.0
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
Priority: Minor
Fix For: 1.1.3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4399) use data size ratio in liveRatio
instead of live size : serialized throughput
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4399:
--------------------------------------
Attachment: 4399-v2.txt
Patch to split out addAllWithSizeDelta to make it clear when we try to do an unsupported operation.
> use data size ratio in liveRatio instead of live size : serialized throughput
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-4399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4399
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.1.3
>
> Attachments: 4399-v2.txt, 4399.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4399) use data size ratio in liveRatio
instead of live size : serialized throughput
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4399:
--------------------------------------
Attachment: 4399.txt
patch attached. primarily this means that overwritten columns no longer artificially inflate liveRatio.
> use data size ratio in liveRatio instead of live size : serialized throughput
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-4399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4399
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.1.3
>
> Attachments: 4399.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4399) use data size ratio in
liveRatio instead of live size : serialized throughput
Posted by "Sylvain Lebresne (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13404938#comment-13404938 ]
Sylvain Lebresne commented on CASSANDRA-4399:
---------------------------------------------
We'll need to reinitialize sizeDelta to 0 in the do-loop in AtomicSortedColumns.addAllColumns otherwise we'll report buggy numbers when there is contention.
Otherwise lgtm, except maybe that we might want to add in the comment on ISortedColumns.addAll() that the returned long is a delta and is not always defined correctly (I am not a fan how having the return value not always be a valid value but I guess it might a necessary evil for performance).
> use data size ratio in liveRatio instead of live size : serialized throughput
> -----------------------------------------------------------------------------
>
> Key: CASSANDRA-4399
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4399
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Priority: Minor
> Fix For: 1.1.3
>
> Attachments: 4399.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira