You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/12/23 02:58:42 UTC

[GitHub] [rocketmq] lizhimins commented on a diff in pull request #5709: [ISSUE #5708]Fix NamesrvStartup can't print config when use -p command

lizhimins commented on code in PR #5709:
URL: https://github.com/apache/rocketmq/pull/5709#discussion_r1056002967


##########
namesrv/src/main/java/org/apache/rocketmq/namesrv/NamesrvStartup.java:
##########
@@ -42,7 +42,8 @@
 
 public class NamesrvStartup {
 
-    private static Logger log;
+    private final static Logger LOGGER = LoggerFactory.getLogger(LoggerName.NAMESRV_LOGGER_NAME);
+    private final static Logger LOGGER_CONSOLE = LoggerFactory.getLogger(LoggerName.NAMESRV_CONSOLE_LOGGER_NAME);

Review Comment:
   keep log format may better
   
   https://docs.oracle.com/javase/specs/jls/se17/html/jls-4.html
   
   https://stackoverflow.com/questions/1417190/should-a-static-final-logger-be-declared-in-upper-case/1417216#1417216
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org