[jira] [Commented] (CB-2052) add option to pass the config file by name

["Patrick Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530130#comment-13530130 ] 

Patrick Mueller commented on CB-2052:
-------------------------------------

I like.

Coupla things though:

* --config sounds like a better option name
* that option should not be allowed in the config file itself; perhaps in the future it's inclusion in the config file could mean that you should include an ADDITIONAL config file, but that sounds ... complicated (to get all the cases right)
* config file should be reported at start up time, and in other diagnostic locations, like the other options
* should probably throw a fatal error if the specified config file can't be found/read
                
> add option to pass the config file by name
> ------------------------------------------
>
>                 Key: CB-2052
>                 URL: https://issues.apache.org/jira/browse/CB-2052
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: weinre
>            Reporter: Patrick Mueller
>            Assignee: Patrick Mueller
>         Attachments: 13.patch
>
>
> From Corey Gilmore via https://github.com/apache/incubator-cordova-weinre/pull/13
> Original text:
> Add the --optionsFile cli parameter to allow passing the path to an options file, which currently is hardcoded to ~/.weinre/server.properties. This makes makes it easier to run as a Windows service using something like this:
> Windows Registry Editor Version 5.00
> {noformat}
>     [HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\services\weinre]
>     "Type"=dword:00000010
>     "Start"=dword:00000002
>     "ErrorControl"=dword:00000001
>     "ImagePath"="C:\\Path\\To\\srvany.exe"
>     "DisplayName"="weinre"
>     "WOW64"=dword:00000001
>     "ObjectName"="LocalSystem"
>     [HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\services\weinre\Parameters]
>     "Application"="\"C:\\Path\\To\\nodejs\\node.exe\" C:\\Path\\To\\node_modules\\weinre\\weinre  --optionsFile C:\\Path\\To\\server.properties"
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira