You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2018/01/12 15:41:00 UTC

[GitHub] spark pull request #5475: [SPARK-6844][SQL] Clean up accumulators used in In...

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5475#discussion_r161253866
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/columnar/PartitionBatchPruningSuite.scala ---
    @@ -39,6 +39,8 @@ class PartitionBatchPruningSuite extends FunSuite with BeforeAndAfterAll with Be
     
         // Enable in-memory partition pruning
         setConf(SQLConf.IN_MEMORY_PARTITION_PRUNING, "true")
    +    // Enable in-memory table scan accumulators
    +    setConf("spark.sql.inMemoryTableScanStatistics.enable", "true")
    --- End diff --
    
    Why not setting `spark.sql.inMemoryTableScanStatistics.enable` back `false`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org