[GitHub] [flink-kubernetes-operator] mxm commented on a diff in pull request #574: [FLINK-31827] Discard old format scaling history

["mxm (via GitHub)" <gi...@apache.org>]

mxm commented on code in PR #574:
URL: https://github.com/apache/flink-kubernetes-operator/pull/574#discussion_r1175535065


##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/AutoScalerInfo.java:
##########
@@ -95,7 +95,7 @@ public SortedMap<Instant, CollectedMetrics> getMetricHistory() {
 
         try {
             return YAML_MAPPER.readValue(decompress(historyYaml), new TypeReference<>() {});
-        } catch (JsonProcessingException e) {
+        } catch (JacksonException e) {

Review Comment:
   I deliberately did not catch Exception, just to avoid masking other errors, but we certainly can.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org