[GitHub] [iotdb] JackieTien97 commented on a change in pull request #4431: [IOTDB-2031] Fix incorrect result of descending query with value filter in cluster

[GitBox <gi...@apache.org>]

JackieTien97 commented on a change in pull request #4431:
URL: https://github.com/apache/iotdb/pull/4431#discussion_r753006705



##########
File path: server/src/main/java/org/apache/iotdb/db/query/reader/series/SeriesReader.java
##########
@@ -231,6 +232,10 @@ protected DescPriorityMergeReader getDescPriorityMergeReader() {
     return new DescPriorityMergeReader();
   }
 
+  public static Filter defaultTimeFilter(boolean ascending) {
+    return ascending ? TimeFilter.gtEq(Long.MIN_VALUE) : TimeFilter.ltEq(Long.MAX_VALUE);
+  }
+

Review comment:
       You can move the method into `TimeFilter` class and add java doc for this method to indicate that it will return a timefilter thta will always satisfy any time.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org