You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/02/20 13:39:19 UTC
[GitHub] [maven-integration-testing] cstamas opened a new pull request, #244: [MNG-7679] Single Mojo no POM -> NPE
cstamas opened a new pull request, #244:
URL: https://github.com/apache/maven-integration-testing/pull/244
IT for this use case, Maven 3.9.0 suffers from this, is excluded. I guess some Maven 4.x suffers as well?
---
https://issues.apache.org/jira/browse/MNG-7679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #244: [MNG-7679] Single Mojo no POM -> NPE
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #244:
URL: https://github.com/apache/maven-integration-testing/pull/244#discussion_r1112011066
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7679SingleMojoNoPomTest.java:
##########
@@ -0,0 +1,64 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-7679">MNG-7679</a>.
+ * Executing single mojo without POM should not NPE.
+ *
+ */
+class MavenITmng7679SingleMojoNoPomTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ public MavenITmng7679SingleMojoNoPomTest()
+ {
+ super( "(,3.9.0),(3.9.0,)" );
Review Comment:
Let's enumerate which version(s) to leave out:
* 3.8.7
* 3.9.0
* 4.0.0-alpha4
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #244: [MNG-7679] Single Mojo no POM -> NPE
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #244:
URL: https://github.com/apache/maven-integration-testing/pull/244#discussion_r1112015158
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7679SingleMojoNoPomTest.java:
##########
@@ -0,0 +1,64 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-7679">MNG-7679</a>.
+ * Executing single mojo without POM should not NPE.
+ *
+ */
+class MavenITmng7679SingleMojoNoPomTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ public MavenITmng7679SingleMojoNoPomTest()
+ {
+ super( "(,3.9.0),(3.9.0,)" );
Review Comment:
Ah, right!
`[3,8.8,3.9.0),[3.9.1,4.0.0-alpha-4),[4.0.0-alpha-5,)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] asfgit closed pull request #244: [MNG-7679] Single Mojo no POM -> NPE
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #244: [MNG-7679] Single Mojo no POM -> NPE
URL: https://github.com/apache/maven-integration-testing/pull/244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on pull request #244: [MNG-7679] Single Mojo no POM -> NPE
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #244:
URL: https://github.com/apache/maven-integration-testing/pull/244#issuecomment-1437125292
Pushed what I have locally, but locally still skips 3.9.1-SNAPSHOT :disappointed:
@michael-o pls look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #244: [MNG-7679] Single Mojo no POM -> NPE
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on code in PR #244:
URL: https://github.com/apache/maven-integration-testing/pull/244#discussion_r1111975381
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7679SingleMojoNoPomTest.java:
##########
@@ -0,0 +1,64 @@
+package org.apache.maven.it;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for <a href="https://issues.apache.org/jira/browse/MNG-7679">MNG-7679</a>.
+ * Executing single mojo without POM should not NPE.
+ *
+ */
+class MavenITmng7679SingleMojoNoPomTest
+ extends AbstractMavenIntegrationTestCase
+{
+
+ public MavenITmng7679SingleMojoNoPomTest()
+ {
+ super( "(,3.9.0),(3.9.0,)" );
Review Comment:
`[3.8.8,)` All three are broken and need fíxing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org