You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/10/20 01:54:31 UTC
[GitHub] [incubator-yunikorn-core] wilfred-s opened a new pull request #218: [YUNIKORN-445] Panic in Resource.String()
wilfred-s opened a new pull request #218:
URL: https://github.com/apache/incubator-yunikorn-core/pull/218
The String method of Resource is not nil safe which causes a panic to be
logged instead of a proper message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #218: [YUNIKORN-445] Panic in Resource.String()
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #218:
URL: https://github.com/apache/incubator-yunikorn-core/pull/218#issuecomment-712578422
Hi @wilfred-s seems like there is a conflict, could you please fix it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] codecov[bot] commented on pull request #218: [YUNIKORN-445] Panic in Resource.String()
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #218:
URL: https://github.com/apache/incubator-yunikorn-core/pull/218#issuecomment-712539319
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218?src=pr&el=h1) Report
> Merging [#218](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-yunikorn-core/commit/0ba29ff68f893a509ea355fb9caee42cf2f154b7?el=desc) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #218 +/- ##
==========================================
+ Coverage 60.94% 60.99% +0.04%
==========================================
Files 67 67
Lines 5774 5776 +2
==========================================
+ Hits 3519 3523 +4
+ Misses 2112 2111 -1
+ Partials 143 142 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [pkg/common/resources/resources.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218/diff?src=pr&el=tree#diff-cGtnL2NvbW1vbi9yZXNvdXJjZXMvcmVzb3VyY2VzLmdv) | `96.12% <100.00%> (+0.02%)` | :arrow_up: |
| [pkg/events/event\_publisher.go](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218/diff?src=pr&el=tree#diff-cGtnL2V2ZW50cy9ldmVudF9wdWJsaXNoZXIuZ28=) | `100.00% <0.00%> (+11.11%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218?src=pr&el=footer). Last update [0ba29ff...d439790](https://codecov.io/gh/apache/incubator-yunikorn-core/pull/218?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] wilfred-s merged pull request #218: [YUNIKORN-445] Panic in Resource.String()
Posted by GitBox <gi...@apache.org>.
wilfred-s merged pull request #218:
URL: https://github.com/apache/incubator-yunikorn-core/pull/218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] yangwwei commented on pull request #218: [YUNIKORN-445] Panic in Resource.String()
Posted by GitBox <gi...@apache.org>.
yangwwei commented on pull request #218:
URL: https://github.com/apache/incubator-yunikorn-core/pull/218#issuecomment-714219196
hi @wilfred-s could u pls fix the conflict and merge this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-core] TravisBuddy commented on pull request #218: [YUNIKORN-445] Panic in Resource.String()
Posted by GitBox <gi...@apache.org>.
TravisBuddy commented on pull request #218:
URL: https://github.com/apache/incubator-yunikorn-core/pull/218#issuecomment-712539307
Hey @wilfred-s,
Your changes look good to me!
<a href="https://travis-ci.org/apache/incubator-yunikorn-core/builds/737269601">View build log</a>
###### TravisBuddy Request Identifier: b4dfdbf0-1277-11eb-af4f-e3a6e0ba4ce0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org