You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/13 14:13:00 UTC
[GitHub] [iotdb] MrQuansy opened a new pull request, #7971: [IOTDB-4896] Fix error in closing a tsFileProcessor with an empty memtable
MrQuansy opened a new pull request, #7971:
URL: https://github.com/apache/iotdb/pull/7971
Now, when executing some inserting requests and then deleting all data, there will be an empty memtable in the tsfileProcessor. When executing flush request and closing this tsfileProcessor, iotdb server will block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] MrQuansy commented on a diff in pull request #7971: [IOTDB-4896] Fix error in closing a TsFileProcessor with an empty memtable
Posted by GitBox <gi...@apache.org>.
MrQuansy commented on code in PR #7971:
URL: https://github.com/apache/iotdb/pull/7971#discussion_r1022261002
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java:
##########
@@ -1270,7 +1273,7 @@ private void endFile() throws IOException, TsFileProcessorException {
logger.info("Start to end file {}", tsFileResource);
long closeStartTime = System.currentTimeMillis();
writer.endFile();
- tsFileResource.serialize();
+ // tsFileResource.serialize();
Review Comment:
fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou merged pull request #7971: [IOTDB-4896] Fix error in closing a TsFileProcessor with an empty memtable
Posted by GitBox <gi...@apache.org>.
HTHou merged PR #7971:
URL: https://github.com/apache/iotdb/pull/7971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a diff in pull request #7971: [IOTDB-4896] Fix error in closing a TsFileProcessor with an empty memtable
Posted by GitBox <gi...@apache.org>.
HTHou commented on code in PR #7971:
URL: https://github.com/apache/iotdb/pull/7971#discussion_r1022249691
##########
server/src/main/java/org/apache/iotdb/db/engine/storagegroup/TsFileProcessor.java:
##########
@@ -1270,7 +1273,7 @@ private void endFile() throws IOException, TsFileProcessorException {
logger.info("Start to end file {}", tsFileResource);
long closeStartTime = System.currentTimeMillis();
writer.endFile();
- tsFileResource.serialize();
+ // tsFileResource.serialize();
Review Comment:
Why do you remove this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org