You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2019/07/17 00:59:36 UTC
[GitHub] [hbase] xcangCRM commented on a change in pull request #387:
HBASE-22642 Make move operations of RSGroup idempotent
xcangCRM commented on a change in pull request #387: HBASE-22642 Make move operations of RSGroup idempotent
URL: https://github.com/apache/hbase/pull/387#discussion_r304181915
##########
File path: hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
##########
@@ -177,10 +177,7 @@ private void checkServersAndTables(Set<Address> servers, Set<TableName> tables,
+ " does not exist.");
}
RSGroupInfo srcGrp = new RSGroupInfo(tmpSrcGrp);
- if (srcGrp.getName().equals(targetGroupName)) {
Review comment:
on line 167, need to change the javadoc "@throws IOException if nulls or if servers and tables not belong to the same group"
this is not accurate anymore :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services