[GitHub] cassandra-dtest pull request #41: 14421

[dineshjoshi <gi...@git.apache.org>]

Github user dineshjoshi commented on a diff in the pull request:

    https://github.com/apache/cassandra-dtest/pull/41#discussion_r245848691
  
    --- Diff: upgrade_tests/thrift_upgrade_test.py ---
    @@ -350,29 +469,41 @@ def test_sparse_supercolumn_with_renames(self):
             client.transport.open()
             client.set_keyspace('ks')
     
    -        cf = _create_sparse_super_cf('sparse_super_1')
    -        client.system_add_column_family(cf)
    +        _create_sparse_super_cf(client, 'sparse_super_1')
    +
    +        #The alter after was failing claiming the column family didn't exist.
    +        #This test is so slow and it's Thrift and going away "soon" and we
    +        #Don't run it on every commit so just sleep
    +        import time
    +        time.sleep(5)
    --- End diff --
    
    Do we want to sleep for a fixed duration or keep retrying patiently until it succeeds?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org