[GitHub] [qpid-dispatch] ted-ross commented on a change in pull request #508: DISPATCH-1342 Replaced mutex with spin lock on qd_message content

[GitBox <gi...@apache.org>]

ted-ross commented on a change in pull request #508: DISPATCH-1342 Replaced mutex with spin lock on qd_message content
URL: https://github.com/apache/qpid-dispatch/pull/508#discussion_r288120782
 
 

 ##########
 File path: src/message.c
 ##########
 @@ -933,7 +933,7 @@ void qd_message_free(qd_message_t *in_msg)
         // counts starting with the msg cursor.  If the buffer count drops to
         // zero we can free it.
         //
-        LOCK(content->lock);
 
 Review comment:
   Why not add the '&' to the macro rather than having to add '&' to all of the invocations?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org