You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Phil Steitz (JIRA)" <ji...@apache.org> on 2010/02/15 03:29:28 UTC
[jira] Closed: (DBCP-280) SequencedHashMap constructor calls
overridable method; throws Error
[ https://issues.apache.org/jira/browse/DBCP-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phil Steitz closed DBCP-280.
----------------------------
> SequencedHashMap constructor calls overridable method; throws Error
> -------------------------------------------------------------------
>
> Key: DBCP-280
> URL: https://issues.apache.org/jira/browse/DBCP-280
> Project: Commons Dbcp
> Issue Type: Bug
> Reporter: Sebb
>
> The constructor SequencedHashMap(Map) calls the public non-final method putAll().
> This is likely to cause problems if the class is ever extended. Possible solution: extract the code into a common private method.
> The next() method also throws an Error if the return type is unexpected.
> It should probably return IllegalStateException or similar.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.