[GitHub] [spark] LuciferYang commented on a diff in pull request #36529: [SPARK-39102][CORE][SQL] Add checkstyle rules to disabled use of Guava's `Files.createTempDir()`

[GitBox <gi...@apache.org>]

LuciferYang commented on code in PR #36529:
URL: https://github.com/apache/spark/pull/36529#discussion_r871954838


##########
common/network-common/src/main/java/org/apache/spark/network/util/JavaUtils.java:
##########
@@ -362,6 +364,18 @@ public static byte[] bufferToArray(ByteBuffer buffer) {
     }
   }
 
+  /**
+   * Create a temporary directory inside `java.io.tmpdir`. The directory will be
+   * automatically deleted when the VM shuts down.
+   */
+  public static File createTempDir() throws IOException {

Review Comment:
   This method is added instead of using `Utils.createTempDir()` directly because `Utils.createTempDir()` defined in `core` module.
   
   Does this method need to maintain exactly the same logic as `Utils.createTempDir()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org