[GitHub] [maven-plugin-tools] michael-o commented on a diff in pull request #126: [MPLUGIN-410] Create implementation attribute for @Parameter

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #126:
URL: https://github.com/apache/maven-plugin-tools/pull/126#discussion_r928564204


##########
maven-plugin-annotations/src/main/java/org/apache/maven/plugins/annotations/Parameter.java:
##########
@@ -72,6 +72,13 @@
      */
     String defaultValue() default "";
 
+    /**
+     * Defines the implementation in the case the parameter type is an interface.
+     *
+     * @return the implementation class name
+     */
+    Class<?> implementation() default Object.class;

Review Comment:
   Question: what if the class will only be available at runtime by the user, how can it be provided here? The previous code used strings, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org