[GitHub] [spark] pan3793 commented on a diff in pull request #41746: [SPARK-44198][CORE] Support propagation of the log level to the executors

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #41746:
URL: https://github.com/apache/spark/pull/41746#discussion_r1271306672


##########
core/src/main/scala/org/apache/spark/internal/config/package.scala:
##########
@@ -2244,6 +2244,14 @@ package object config {
       .booleanConf
       .createWithDefault(false)
 
+  private[spark] val EXECUTOR_ALLOW_SYNC_LOG_LEVEL =
+    ConfigBuilder("spark.executor.sync.log.level")

Review Comment:
   We should be careful to use `.` to introduce the unnecessary configuration namespace, suggested alternatives are
   
   - `spark.executor.syncLogLevel`
   - `spark.executor.syncLogLevel.enabled`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org