You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/02/29 15:20:03 UTC

[GitHub] [fluo] jkosh44 commented on a change in pull request #1087: Add Oracle count functionality

jkosh44 commented on a change in pull request #1087: Add Oracle count functionality
URL: https://github.com/apache/fluo/pull/1087#discussion_r386034681
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/client/FluoAdminImpl.java
 ##########
 @@ -516,6 +516,22 @@ public boolean oracleExists() {
     return oracleExists(getAppCurator());
   }
 
+  public static int numOracles(CuratorFramework curator) {
+    int numOracles = 0;
+    if (oracleExists(curator)) {
+      try {
+        numOracles += curator.getChildren().forPath(ZookeeperPath.ORACLE_SERVER).size();
 
 Review comment:
   I'm a little concerned that the LeaderLatch may create some Ephemeral ZNodes during leader election that would cause this to be temporarily inaccurate.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services