You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/21 10:58:28 UTC
[GitHub] [pulsar] nahguam opened a new pull request, #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
nahguam opened a new pull request, #16159:
URL: https://github.com/apache/pulsar/pull/16159
Use metadataServiceUri in favor of zkServers
### Motivation
The docs still refer to using the deprecated `zkServers` in the [bare-metal deployment guide](https://pulsar.apache.org/docs/deploy-bare-metal/#deploy-a-bookkeeper-cluster). Its replacement, `metadataServiceUri` is also missing from the [bookkeeper configuration](https://pulsar.apache.org/docs/reference-configuration/#bookkeeper).
### Modifications
* Update the bare-metal deployment guid to use `metadataServiceUri` instead of `zkServers`
* Add `metadataServiceUri` to the bookkeeper configuration
* Mark `zkServers` as deprecated in the bookkeeper configuration
* Fix a mistake in bookkeeper.conf that refers to `zkLedgers` instead of `zkServers`
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
- [x] This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [ ] `doc-not-needed`
(Please explain why)
- [x] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Raven888888 commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
Raven888888 commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1214675963
For multiple zk, is it comma separated like this?
`metadataServiceUri=zk://my-zk-1:2181/ledgers,zk://my-zk-2:2181/ledgers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on a diff in pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on code in PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#discussion_r902540960
##########
site2/docs/deploy-bare-metal.md:
##########
@@ -326,15 +326,15 @@ Flag | Description
[BookKeeper](https://bookkeeper.apache.org) handles all persistent data storage in Pulsar. You need to deploy a cluster of BookKeeper bookies to use Pulsar. You can choose to run a **3-bookie BookKeeper cluster**.
-You can configure BookKeeper bookies using the [`conf/bookkeeper.conf`](reference-configuration.md#bookkeeper) configuration file. The most important step in configuring bookies for our purposes here is ensuring that [`zkServers`](reference-configuration.md#bookkeeper-zkServers) is set to the connection string for the ZooKeeper cluster. The following is an example:
+You can configure BookKeeper bookies using the [`conf/bookkeeper.conf`](reference-configuration.md#bookkeeper) configuration file. The most important step in configuring bookies for our purposes here is ensuring that `metadataServiceUri` is set to the URI for the ZooKeeper cluster. The following is an example:
```properties
-zkServers=zk1.us-west.example.com:2181,zk2.us-west.example.com:2181,zk3.us-west.example.com:2181
+metadataServiceUri=zk://zk1.us-west.example.com:2181/ledgers
Review Comment:
I think `/ledgers` is not required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1352461309
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun merged pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
tisonkun merged PR #16159:
URL: https://github.com/apache/pulsar/pull/16159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] DaveDuggins commented on a diff in pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
DaveDuggins commented on code in PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#discussion_r959627014
##########
conf/bookkeeper.conf:
##########
@@ -631,10 +631,10 @@ diskCheckInterval=10000
## Metadata Service settings
#############################################################################
-# metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location
+# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
# Examples:
-# - metadataServiceUri=metadata-store:zk:my-zk-1:2181
-# - metadataServiceUri=metadata-store:etcd:http://my-etcd:2379
+# - metadataServiceUri=zk://my-zk-1:2181/ledgers
+# - metadataServiceUri=etcd:http://my-etcd:2379
Review Comment:
> Hi @DaveDuggins Does this look ok
Yes. Anonymitaet pinged me for reference. I'm not the approver. We still need a committer to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] DaveDuggins commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
DaveDuggins commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1271835864
I'm working this now. Thank you Sijie!
On Fri, Oct 7, 2022 at 4:59 AM Dave Maughan ***@***.***>
wrote:
> @nahguam <https://github.com/nahguam> can you pls resolve the conflicting
> files?
>
> @momo-jun <https://github.com/momo-jun> Done
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/pulsar/pull/16159#issuecomment-1271316905>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AWOUODYPV7KDNK6NNAGGFOLWB7Q6FANCNFSM5ZL42OWQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a diff in pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on code in PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#discussion_r910512516
##########
conf/bookkeeper.conf:
##########
@@ -631,10 +631,10 @@ diskCheckInterval=10000
## Metadata Service settings
#############################################################################
-# metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location
+# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
Review Comment:
```suggestion
# Metadata service URI that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
```
Capitalize proper nouns correctly. https://docs.google.com/document/d/1lc5j4RtuLIzlEYCBo97AC8-U_3Erzs_lxpkDuseU0n4/edit#bookmark=id.je5thtkj42cb
```suggestion
# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
```
##########
site2/docs/reference-configuration.md:
##########
@@ -72,7 +72,8 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|flushInterval|How long the interval to flush ledger index pages to disk, in milliseconds. Flushing index files will introduce much random disk I/O. If separating journal dir and ledger dirs each on different devices, flushing would not affect performance. But if putting journal dir and ledger dirs on same device, performance degrade significantly on too frequent flushing. You can consider increment flush interval to get better performance, but you need to pay more time on bookie server restart after failure.|60000|
|bookieDeathWatchInterval|Interval to watch whether bookie is dead or not, in milliseconds|1000|
|allowStorageExpansion|Allow the bookie storage to expand. Newly added ledger and index dirs must be empty.|false|
-|zkServers|A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
+|metadataServiceUri|Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
+|zkServers|Deprecated in favor of using `metadataServiceUri`. A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
Review Comment:
```suggestion
|zkServers|Deprecated in favor of using `metadataServiceUri`. A list of one or more servers on which ZooKeeper is running. The server list can be comma-separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
```
```suggestion
|zkServers|Deprecated in favor of using `metadataServiceUri`. A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
```
##########
conf/bookkeeper.conf:
##########
@@ -631,10 +631,10 @@ diskCheckInterval=10000
## Metadata Service settings
#############################################################################
-# metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location
+# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
# Examples:
-# - metadataServiceUri=metadata-store:zk:my-zk-1:2181
-# - metadataServiceUri=metadata-store:etcd:http://my-etcd:2379
+# - metadataServiceUri=zk://my-zk-1:2181/ledgers
+# - metadataServiceUri=etcd:http://my-etcd:2379
Review Comment:
FYI @momo-jun @daveduggins
##########
site2/docs/reference-configuration.md:
##########
@@ -72,7 +72,8 @@ BookKeeper is a replicated log storage system that Pulsar uses for durable stora
|flushInterval|How long the interval to flush ledger index pages to disk, in milliseconds. Flushing index files will introduce much random disk I/O. If separating journal dir and ledger dirs each on different devices, flushing would not affect performance. But if putting journal dir and ledger dirs on same device, performance degrade significantly on too frequent flushing. You can consider increment flush interval to get better performance, but you need to pay more time on bookie server restart after failure.|60000|
|bookieDeathWatchInterval|Interval to watch whether bookie is dead or not, in milliseconds|1000|
|allowStorageExpansion|Allow the bookie storage to expand. Newly added ledger and index dirs must be empty.|false|
-|zkServers|A list of one of more servers on which zookeeper is running. The server list can be comma separated values, for example: zkServers=zk1:2181,zk2:2181,zk3:2181.|localhost:2181|
+|metadataServiceUri|Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
Review Comment:
```suggestion
|metadataServiceUri|Metadata service URI that BookKeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
```
```suggestion
|metadataServiceUri|Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location.||
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
nahguam commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1226944371
Hi @DaveDuggins Does this look ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#discussion_r1021106811
##########
conf/bookkeeper.conf:
##########
@@ -642,10 +642,10 @@ diskCheckInterval=10000
## Metadata Service settings
#############################################################################
-# metadata service uri that bookkeeper is used for loading corresponding metadata driver and resolving its metadata service location
+# Metadata service uri that bookkeeper uses for loading the corresponding metadata driver and resolving its metadata service location
# Examples:
-# - metadataServiceUri=metadata-store:zk:my-zk-1:2181
-# - metadataServiceUri=metadata-store:etcd:http://my-etcd:2379
+# - metadataServiceUri=zk://my-zk-1:2181/ledgers
+# - metadataServiceUri=etcd:http://my-etcd:2379
Review Comment:
I'm not quite sure whether this config pattern is correct.
I'm using the `metadata-store:` variant in prod env.
cc @merlimat @eolivelli
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1367030344
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1367030167
Merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1304996678
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1264202583
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] momo-jun commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
momo-jun commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1269199004
@nahguam can you pls resolve the conflicting files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on a diff in pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
nahguam commented on code in PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#discussion_r903567496
##########
site2/docs/deploy-bare-metal.md:
##########
@@ -326,15 +326,15 @@ Flag | Description
[BookKeeper](https://bookkeeper.apache.org) handles all persistent data storage in Pulsar. You need to deploy a cluster of BookKeeper bookies to use Pulsar. You can choose to run a **3-bookie BookKeeper cluster**.
-You can configure BookKeeper bookies using the [`conf/bookkeeper.conf`](reference-configuration.md#bookkeeper) configuration file. The most important step in configuring bookies for our purposes here is ensuring that [`zkServers`](reference-configuration.md#bookkeeper-zkServers) is set to the connection string for the ZooKeeper cluster. The following is an example:
+You can configure BookKeeper bookies using the [`conf/bookkeeper.conf`](reference-configuration.md#bookkeeper) configuration file. The most important step in configuring bookies for our purposes here is ensuring that `metadataServiceUri` is set to the URI for the ZooKeeper cluster. The following is an example:
```properties
-zkServers=zk1.us-west.example.com:2181,zk2.us-west.example.com:2181,zk3.us-west.example.com:2181
+metadataServiceUri=zk://zk1.us-west.example.com:2181/ledgers
Review Comment:
If I do the same connect string as in the `initialize-cluster-metadata` command - `zk:zookeeper:2181` - I get:
```
2022-06-22T10:22:37,902+0000 [main] ERROR org.apache.bookkeeper.server.Main - Failed to build bookie server
org.apache.bookkeeper.bookie.BookieException$MetadataStoreException: Failed to initialize metadata bookie driver
...
Caused by: org.apache.bookkeeper.meta.exceptions.MetadataException: java.lang.IllegalArgumentException: Invalid metadata service URI format: zk:zookeeper:2181
...
Caused by: java.lang.IllegalArgumentException: Invalid metadata service URI format: zk:zookeeper:2181
...
```
If I use a URI but omit the `/ledgers` path - `zk://zookeeper:2181` - I get:
```
[main] ERROR org.apache.bookkeeper.server.Main - Failed to build bookie server
java.lang.IllegalArgumentException: Path length must be > 0
...
```
Only `zk://zookeeper:2181/ledgers` is working for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nahguam commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
nahguam commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1271316905
> @nahguam can you pls resolve the conflicting files?
@momo-jun Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #16159: [improve][docs] Use metadataServiceUri in favor of zkServers
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #16159:
URL: https://github.com/apache/pulsar/pull/16159#issuecomment-1308426221
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/16159?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16159](https://codecov.io/gh/apache/pulsar/pull/16159?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (23e9284) into [master](https://codecov.io/gh/apache/pulsar/commit/27186a1ee9298802a12f1d42f9bba03d8f3eea77?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (27186a1) will **decrease** coverage by `16.04%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/pulsar/pull/16159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16159 +/- ##
=============================================
- Coverage 45.61% 29.57% -16.05%
+ Complexity 10728 5568 -5160
=============================================
Files 752 613 -139
Lines 72521 58391 -14130
Branches 7791 6087 -1704
=============================================
- Hits 33083 17270 -15813
- Misses 35769 38662 +2893
+ Partials 3669 2459 -1210
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `29.57% <ø> (-16.05%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/16159?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/org/apache/pulsar/client/api/RawReader.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9hcGkvUmF3UmVhZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pulsar/broker/admin/v1/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Ccm9rZXJzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pulsar/broker/admin/v2/Brokers.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9Ccm9rZXJzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pulsar/broker/admin/v1/Clusters.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9DbHVzdGVycy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pulsar/broker/admin/v1/Properties.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92MS9Qcm9wZXJ0aWVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../org/apache/pulsar/client/impl/RawMessageImpl.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Jhd01lc3NhZ2VJbXBsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/pulsar/broker/admin/v2/ResourceGroups.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92Mi9SZXNvdXJjZUdyb3Vwcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ar/common/naming/PartitionedManagedLedgerInfo.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9uYW1pbmcvUGFydGl0aW9uZWRNYW5hZ2VkTGVkZ2VySW5mby5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/pulsar/broker/admin/impl/ResourceQuotasBase.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi9pbXBsL1Jlc291cmNlUXVvdGFzQmFzZS5qYXZh) | `0.00% <0.00%> (-96.43%)` | :arrow_down: |
| [...he/pulsar/broker/service/AnalyzeBacklogResult.java](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL0FuYWx5emVCYWNrbG9nUmVzdWx0LmphdmE=) | `0.00% <0.00%> (-92.31%)` | :arrow_down: |
| ... and [302 more](https://codecov.io/gh/apache/pulsar/pull/16159/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org