You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2017/06/09 20:06:52 UTC
[GitHub] flink pull request #4098: [FLINK-6880] [runtime] Activate checkstyle for run...
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/4098
[FLINK-6880] [runtime] Activate checkstyle for runtime/iterative
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 6880_activate_checkstyle_for_runtime_iterative
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4098.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4098
----
commit 31d9224a4e5528ec8e763cd8cf4ef0391e3e33ac
Author: Greg Hogan <co...@greghogan.com>
Date: 2017-06-09T16:53:41Z
[FLINK-6880] [runtime] Activate checkstyle for runtime/iterative
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4098: [FLINK-6880] [runtime] Activate checkstyle for run...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4098
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4098: [FLINK-6880] [runtime] Activate checkstyle for runtime/it...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/4098
merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4098: [FLINK-6880] [runtime] Activate checkstyle for run...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/4098#discussion_r124902455
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/iterative/io/SolutionSetFastUpdateOutputCollector.java ---
@@ -18,17 +18,17 @@
package org.apache.flink.runtime.iterative.io;
-import java.io.IOException;
-
import org.apache.flink.runtime.operators.hash.CompactingHashTable;
import org.apache.flink.util.Collector;
+import java.io.IOException;
+
/**
* A {@link Collector} to update the solution set of a workset iteration.
- * <p>
- * The records are written to a HashTable hash table to allow in-memory point updates.
- * <p>
- * Assumption for fast updates: the build side iterator of the hash table is already positioned for the update. This
+ *
+ * <p>The records are written to a HashTable hash table to allow in-memory point updates.
--- End diff --
duplicate hash table
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---