Re: svn commit: r1614703 - in /subversion/branches/authzperf: BRANCH-README subversion/include/svn_string.h subversion/libsvn_repos/authz.c subversion/libsvn_subr/string.c

[Branko Čibej <br...@wandisco.com>]

[re-sending to the correct list]

On 04.08.2014 01:48, Branko Čibej wrote:
> On 30.07.2014 18:27, stefan2@apache.org wrote:
>> Author: stefan2
>> Date: Wed Jul 30 16:27:44 2014
>> New Revision: 1614703
>> +  for ( ; pos; pos = strstr(str->data + current, to_find), ++replacements)
>> +    {
>> +      apr_size_t to_copy = pos - str->data - current;
>
> This declaration shadows the one a few lines further up.
>
> Stefan^2 , are you compiling in maintainer mode? If not, please do; If
> yes, please make sure you don't commit code that cause new warnings.
> They're really very distracting. Currently about 3/4 of all warnings
> (from gcc and/or clang) are emitted from code you wrote.
>
> -- Brane

-- 
Branko Čibej | Director of Subversion
WANdisco | Realising the impossibilities of Big Data
e. brane@wandisco.com