You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/04/10 08:10:27 UTC
[GitHub] [spark] gengliangwang opened a new pull request #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
gengliangwang opened a new pull request #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Show submitted time and duration of a job in its details page
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
When we check job details from the SQL execution page, it will be more convenient if we can get the submission time and duration from the job page, instead of finding the info from job list page.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
Yes. After changes, the job details page shows the submitted time and duration.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Manual check
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612225934
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25794/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612225934
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25794/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612177525
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612177007
**[Test build #121101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121101/testReport)** for PR 28179 at commit [`f1c3f91`](https://github.com/apache/spark/commit/f1c3f917623ce08f4e72ef0316c4a7aa4fd7f9b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-613100840
LGTM. I agree to consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611987210
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611982398
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121069/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611930215
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611986882
**[Test build #121083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121083/testReport)** for PR 28179 at commit [`11c7bb3`](https://github.com/apache/spark/commit/11c7bb398a1b7fa8714c5c0f0f8761ea924f26a6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612223161
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612272040
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612225927
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-613157347
Merging to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612228169
**[Test build #121104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121104/testReport)** for PR 28179 at commit [`f1c3f91`](https://github.com/apache/spark/commit/f1c3f917623ce08f4e72ef0316c4a7aa4fd7f9b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611930221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25759/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612177007
**[Test build #121101 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121101/testReport)** for PR 28179 at commit [`f1c3f91`](https://github.com/apache/spark/commit/f1c3f917623ce08f4e72ef0316c4a7aa4fd7f9b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-613093765
@srowen Yes, stage page:
SQL page:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611982390
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612223171
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121101/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612177532
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25791/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611986882
**[Test build #121083 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121083/testReport)** for PR 28179 at commit [`11c7bb3`](https://github.com/apache/spark/commit/11c7bb398a1b7fa8714c5c0f0f8761ea924f26a6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612272040
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612272045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121104/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612043744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121083/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on a change in pull request #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on a change in pull request #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#discussion_r406757851
##########
File path: core/src/main/scala/org/apache/spark/ui/jobs/JobDataUtil.scala
##########
@@ -0,0 +1,37 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.spark.ui.jobs
+
+import org.apache.spark.status.api.v1.JobData
+import org.apache.spark.ui.UIUtils
+
+private[ui] object JobDataUtil {
+ def getDuration(jobData: JobData): Option[Long] = {
+ jobData.submissionTime.map { start =>
+ val end = jobData.completionTime.map(_.getTime()).getOrElse(System.currentTimeMillis())
+ end - start.getTime()
+ }
+ }
Review comment:
nit: add a line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612228169
**[Test build #121104 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121104/testReport)** for PR 28179 at commit [`f1c3f91`](https://github.com/apache/spark/commit/f1c3f917623ce08f4e72ef0316c4a7aa4fd7f9b4).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612271442
**[Test build #121104 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121104/testReport)** for PR 28179 at commit [`f1c3f91`](https://github.com/apache/spark/commit/f1c3f917623ce08f4e72ef0316c4a7aa4fd7f9b4).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612043744
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121083/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-613100840
LGTM. I agree with keeping consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611987210
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-613060271
@srowen What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612042677
**[Test build #121083 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121083/testReport)** for PR 28179 at commit [`11c7bb3`](https://github.com/apache/spark/commit/11c7bb398a1b7fa8714c5c0f0f8761ea924f26a6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611932602
**[Test build #121069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121069/testReport)** for PR 28179 at commit [`11c7bb3`](https://github.com/apache/spark/commit/11c7bb398a1b7fa8714c5c0f0f8761ea924f26a6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612177532
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25791/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612043729
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611987214
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25773/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612223171
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121101/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611982115
**[Test build #121069 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121069/testReport)** for PR 28179 at commit [`11c7bb3`](https://github.com/apache/spark/commit/11c7bb398a1b7fa8714c5c0f0f8761ea924f26a6).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612177525
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611982398
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121069/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612223161
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612222856
**[Test build #121101 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121101/testReport)** for PR 28179 at commit [`f1c3f91`](https://github.com/apache/spark/commit/f1c3f917623ce08f4e72ef0316c4a7aa4fd7f9b4).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611985932
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak edited a comment on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
sarutak edited a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-613100840
LGTM. I agree to keep consistency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612043729
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611930221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25759/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611932602
**[Test build #121069 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/121069/testReport)** for PR 28179 at commit [`11c7bb3`](https://github.com/apache/spark/commit/11c7bb398a1b7fa8714c5c0f0f8761ea924f26a6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #28179:
[SPARK-31411][UI] Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611930215
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-613092240
Do other details pages have something similar (sorry being lazy, I could look). I think consistency is a sufficient argument either way; do what other similar pages do
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612173773
@srowen I understand your concerns. However, in the current UI, there is also duration info in the stage/SQL detail page as well. I think it is essential info for *details* page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611982390
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-611987214
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25773/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] sarutak commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
sarutak commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612225475
retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612272045
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121104/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #28179: [SPARK-31411][UI]
Show submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612225927
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on issue #28179: [SPARK-31411][UI] Show
submitted time and duration in job details page
Posted by GitBox <gi...@apache.org>.
srowen commented on issue #28179: [SPARK-31411][UI] Show submitted time and duration in job details page
URL: https://github.com/apache/spark/pull/28179#issuecomment-612043862
The only objection I have is that this is putting more info at the top of the page and pushing the details farther below the fold. Really this whole UX needs an overhaul to organize this better across the top and not just list info down the page. That's out of scope here, but how important is this to add?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org