[GitHub] [spark] Kimahriman commented on a change in pull request #34166: [SPARK-36918][SQL] Ignore types when comparing structs for unionByName

[GitBox <gi...@apache.org>]

Kimahriman commented on a change in pull request #34166:
URL: https://github.com/apache/spark/pull/34166#discussion_r722164642



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/types/DataTypeSuite.scala
##########
@@ -584,6 +585,69 @@ class DataTypeSuite extends SparkFunSuite {
     true,
     ignoreNullability = true)
 
+  def checkEqualsStructurallyByName(
+      from: DataType,
+      to: DataType,
+      expected: Boolean,
+      caseSensitive: Boolean = false): Unit = {
+    val testName = s"equalsStructurallyByName: (from: $from, to: $to, " +

Review comment:
       sure, wasn't sure if that was primarily for bug or when to not add it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org