You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2023/09/01 06:22:44 UTC

[GitHub] [incubator-pekko] He-Pin opened a new pull request, #607: =str Make use of statefulMap to implement zipWithIndex.

He-Pin opened a new pull request, #607:
URL: https://github.com/apache/incubator-pekko/pull/607

   Signed-off-by: He-Pin <he...@gmail.com>
   (cherry picked from commit a855e58bfcd7e48043c5e6d34536c32cd4a97b3f)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on pull request #607: =str Make use of statefulMap to implement zipWithIndex.

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #607:
URL: https://github.com/apache/incubator-pekko/pull/607#issuecomment-1702270945

   Think again about this, And I think we should keep this branch as clean as possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on pull request #607: =str Make use of statefulMap to implement zipWithIndex.

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #607:
URL: https://github.com/apache/incubator-pekko/pull/607#issuecomment-1702261949

   I am not sure we should be cherry picking this PR's onto the `1.0.x` branch. While I understand this fix is largely harmless it sends the wrong impression on the goals of the branch, which is that it is meant to be, as much as possible, a largely untouched version of Akka 2.6 just before BSL changes.
   
   Improvements to areas such as the build (sbt), formatting etc etc are fine and welcome since they don't actually effect the actual runtime behaviour of Pekko but unless we are dealing with CVE's, critical bugs or possible migration features to help people move off Akka we shouldn't be backporting such fixes.
   
   @pjfanning wdyt?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin closed pull request #607: =str Make use of statefulMap to implement zipWithIndex.

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin closed pull request #607: =str Make use of statefulMap to implement zipWithIndex.
URL: https://github.com/apache/incubator-pekko/pull/607


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] mdedetrich commented on pull request #607: =str Make use of statefulMap to implement zipWithIndex.

Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #607:
URL: https://github.com/apache/incubator-pekko/pull/607#issuecomment-1702270745

   > @mdedetrich as we plan to deprecated the statefulmapconcat, if I don't back port this , I need to annotated it with `@nowarn`
   
   Then I think using `@nowarn` makes sense, lets see what @pjfanning says


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org

[GitHub] [incubator-pekko] He-Pin commented on pull request #607: =str Make use of statefulMap to implement zipWithIndex.

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #607:
URL: https://github.com/apache/incubator-pekko/pull/607#issuecomment-1702265868

   @mdedetrich as we plan to deprecated the statefulmapconcat, if I don't back port this , I need to annotated it with `@nowarn`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org