You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "ankitsultana (via GitHub)" <gi...@apache.org> on 2025/03/03 19:34:29 UTC
Re: [PR] Fixing ordering issue in subquery for time column in GAPFILL based queries [pinot]
ankitsultana commented on code in PR #15096:
URL: https://github.com/apache/pinot/pull/15096#discussion_r1978079961
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java:
##########
@@ -270,7 +275,7 @@ private List<Object[]> aggregateGapfilledData(Object timeCol, List<Object[]> buc
}
Map<ExpressionContext, BlockValSet> blockValSetMap = new HashMap<>();
- for (int i = 1; i < dataSchema.getColumnNames().length; i++) {
+ for (int i = 0; i < dataSchema.getColumnNames().length; i++) {
Review Comment:
Can you explain this change? Previously we were skipping block val set for index 0, but now we track all the column in that map. Does it lead to any behavior change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org