You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/10 07:04:28 UTC

[GitHub] [rocketmq-clients] guyinyou commented on a diff in pull request #249: golang: remove redundant configuration

guyinyou commented on code in PR #249:
URL: https://github.com/apache/rocketmq-clients/pull/249#discussion_r990962731


##########
golang/example/consumer/simple_consumer/main.go:
##########
@@ -53,9 +52,8 @@ func main() {
 	golang.ResetLogger()

Review Comment:
   done



##########
golang/example/consumer/simple_consumer/main.go:
##########
@@ -53,9 +52,8 @@ func main() {
 	golang.ResetLogger()
 	// new simpleConsumer instance
 	simpleConsumer, err := golang.NewSimpleConsumer(&golang.Config{
-		Endpoint: Endpoint,
-		Group:    GroupName,
-		Region:   Region,
+		Endpoint:      Endpoint,
+		ConsumerGroup: GroupName,

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org