You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/16 15:44:40 UTC

[GitHub] [incubator-nuttx] acassis opened a new pull request #4563: ESP32/ESP32-C3: Fix bringup, remove "return ret"

acassis opened a new pull request #4563:
URL: https://github.com/apache/incubator-nuttx/pull/4563


   ## Summary
   Fix bringup, remove "return ret"
   ## Impact
   When some device initialization fails it will not forbidden others to be initialized
   ## Testing
   esp32-devkit
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #4563: ESP32/ESP32-C3: Fix bringup, remove "return ret"

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #4563:
URL: https://github.com/apache/incubator-nuttx/pull/4563#issuecomment-921025491


   > @acassis I'm not sure if this is the right path to go.
   > Some components are dependent.
   > For example, if spiflash fails, wireless will also fail.
   
   I agree, but the syslog will report all the failures.
   Since "return ret" doesn't stop the "nsh>" initialization, it is important to have all possible peripherals and devices initialized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis edited a comment on pull request #4563: ESP32/ESP32-C3: Fix bringup, remove "return ret"

Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #4563:
URL: https://github.com/apache/incubator-nuttx/pull/4563#issuecomment-921025491


   > @acassis I'm not sure if this is the right path to go.
   > Some components are dependent.
   > For example, if spiflash fails, wireless will also fail.
   
   I agree, but this the syslog will report all the failures.
   Since "return ret" doesn't stop the "nsh>" initialization, it is important to have all possible peripherals and devices initialized.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] saramonteiro commented on pull request #4563: ESP32/ESP32-C3: Fix bringup, remove "return ret"

Posted by GitBox <gi...@apache.org>.
saramonteiro commented on pull request #4563:
URL: https://github.com/apache/incubator-nuttx/pull/4563#issuecomment-921021560


   @acassis I'm not sure if this is the right path to go.
   Some components are dependent.
   For example, if spiflash fails, wireless will also fail.
    


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] saramonteiro merged pull request #4563: ESP32/ESP32-C3: Fix bringup, remove "return ret"

Posted by GitBox <gi...@apache.org>.
saramonteiro merged pull request #4563:
URL: https://github.com/apache/incubator-nuttx/pull/4563


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] acassis commented on pull request #4563: ESP32/ESP32-C3: Fix bringup, remove "return ret"

Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4563:
URL: https://github.com/apache/incubator-nuttx/pull/4563#issuecomment-921025491


   > @acassis I'm not sure if this is the right path to go.
   > Some components are dependent.
   > For example, if spiflash fails, wireless will also fail.
   
   I agree, but this the syslog will report all the failures.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org