You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by mj...@apache.org on 2018/11/30 01:51:28 UTC
[kafka] branch 2.1 updated: MINOR: avoid miss-leading log statement
for KafkaStreams#close() (#5963)
This is an automated email from the ASF dual-hosted git repository.
mjsax pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/2.1 by this push:
new c142224 MINOR: avoid miss-leading log statement for KafkaStreams#close() (#5963)
c142224 is described below
commit c142224ad6aa90b6e1b4c00dd6dd6478a43a8659
Author: Matthias J. Sax <mj...@apache.org>
AuthorDate: Thu Nov 29 17:51:19 2018 -0800
MINOR: avoid miss-leading log statement for KafkaStreams#close() (#5963)
Reviewers: Bill Bejeck <bi...@confluent.io>, Guozhang Wang <gu...@confluent.io>
---
streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
index 819732a..6e9f2b5 100644
--- a/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
+++ b/streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
@@ -16,7 +16,6 @@
*/
package org.apache.kafka.streams;
-import java.time.Duration;
import org.apache.kafka.clients.admin.AdminClient;
import org.apache.kafka.clients.consumer.KafkaConsumer;
import org.apache.kafka.clients.producer.KafkaProducer;
@@ -63,6 +62,7 @@ import org.apache.kafka.streams.state.internals.StateStoreProvider;
import org.apache.kafka.streams.state.internals.StreamThreadStateStoreProvider;
import org.slf4j.Logger;
+import java.time.Duration;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
@@ -126,7 +126,6 @@ import static org.apache.kafka.common.utils.Utils.getPort;
public class KafkaStreams {
private static final String JMX_PREFIX = "kafka.streams";
- private static final int DEFAULT_CLOSE_TIMEOUT = 0;
// processId is expected to be unique across JVMs and to be used
// in userData of the subscription request to allow assignor be aware
@@ -811,7 +810,7 @@ public class KafkaStreams {
* This will block until all threads have stopped.
*/
public void close() {
- close(DEFAULT_CLOSE_TIMEOUT, TimeUnit.SECONDS);
+ close(Long.MAX_VALUE);
}
/**