[GitHub] [accumulo] lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables

[GitBox <gi...@apache.org>]

lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables
URL: https://github.com/apache/accumulo/pull/1518#discussion_r385327853
 
 

 ##########
 File path: server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java
 ##########
 @@ -697,10 +699,28 @@ private TableId validateTableIdArgument(ByteBuffer tableIdArg, TableOperation op
     }
   }
 
-  // Verify table name arguments are valid, and match any additional restrictions
+  // Verify older table name arguments are valid, and match any additional restrictions
   private String validateTableNameArgument(ByteBuffer tableNameArg, TableOperation op,
       Validator<String> userValidator) throws ThriftTableOperationException {
     String tableName = tableNameArg == null ? null : ByteBufferUtil.toString(tableNameArg);
+    if ((tableName != null) && (tableName.length() > MAX_TABLE_NAME_LEN)) {
+      log.warn("Table names greater than " + MAX_TABLE_NAME_LEN
+          + " characters should be renamed to conform to a 1024 character limit. "
 
 Review comment:
   ```suggestion
             + " characters should be renamed to conform to a "+MAX_TABLE_NAME_LEN+" character limit. "
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services