You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by "eupaphios (via GitHub)" <gi...@apache.org> on 2023/04/05 13:47:35 UTC

[GitHub] [dolphinscheduler] eupaphios opened a new pull request, #13874: Postgresql upsert bug

eupaphios opened a new pull request, #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874

   Postgresql upsert  bug
   
   [https://ibb.co/z70vbhD](url)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] ruanwenjun commented on a diff in pull request #13874: Postgresql upsert bug

Posted by "ruanwenjun (via GitHub)" <gi...@apache.org>.
ruanwenjun commented on code in PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#discussion_r1161397079


##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/TriggerRelationMapper.xml:
##########
@@ -50,6 +50,8 @@
     <insert id="upsert">
         INSERT INTO t_ds_trigger_relation (trigger_code, trigger_type, job_id, create_time, update_time) VALUES(
             #{triggerRelation.triggerCode},#{triggerRelation.triggerType},#{triggerRelation.jobId},#{triggerRelation.createTime},#{triggerRelation.updateTime})
-        ON DUPLICATE KEY UPDATE update_time = #{triggerRelation.updateTime};
+        ON CONFLICT (trigger_code, trigger_type, job_id)

Review Comment:
   Could you please split this method to insert/update?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #13874: Postgresql upsert bug

Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on code in PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#discussion_r1162203633


##########
dolphinscheduler-api/src/main/docker/Dockerfile:
##########
@@ -1,4 +1,4 @@
-#
+#hamileler d vitamini kullanabilir mi

Review Comment:
   ```suggestion
   #
   ```



##########
deploy/docker/docker-compose.yml:
##########
@@ -44,6 +44,8 @@ services:
       ZOO_4LW_COMMANDS_WHITELIST: srvr,ruok,wchs,cons
     volumes:
       - dolphinscheduler-zookeeper:/bitnami/zookeeper
+    ports:
+      - "2181:2181"

Review Comment:
   export no public ports is not the best practice



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] eupaphios closed pull request #13874: presto driver update

Posted by "eupaphios (via GitHub)" <gi...@apache.org>.
eupaphios closed pull request #13874: presto driver update
URL: https://github.com/apache/dolphinscheduler/pull/13874


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on pull request #13874: Postgresql upsert bug

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#issuecomment-1550829115

   Please resolve conflicts. @epuaphios 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Postgresql upsert bug [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#issuecomment-1868147231

   This pull request has been closed because it has not had recent activity. You could reopen it if you try to continue your work, and anyone who are interested in it are encouraged to continue work on this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Postgresql upsert bug [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#issuecomment-1857070158

   This pull request has been automatically marked as stale because it has not had recent activity for 120 days. It will be closed in 7 days if no further activity occurs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] eupaphios closed pull request #13874: Postgresql upsert bug

Posted by "eupaphios (via GitHub)" <gi...@apache.org>.
eupaphios closed pull request #13874: Postgresql upsert bug
URL: https://github.com/apache/dolphinscheduler/pull/13874


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] eupaphios commented on a diff in pull request #13874: Postgresql upsert bug

Posted by "eupaphios (via GitHub)" <gi...@apache.org>.
eupaphios commented on code in PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#discussion_r1162357268


##########
dolphinscheduler-api/src/main/docker/Dockerfile:
##########
@@ -1,4 +1,4 @@
-#
+#hamileler d vitamini kullanabilir mi

Review Comment:
   sorry my fault 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] eupaphios commented on a diff in pull request #13874: Postgresql upsert bug

Posted by "eupaphios (via GitHub)" <gi...@apache.org>.
eupaphios commented on code in PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#discussion_r1162350825


##########
deploy/docker/docker-compose.yml:
##########
@@ -44,6 +44,8 @@ services:
       ZOO_4LW_COMMANDS_WHITELIST: srvr,ruok,wchs,cons
     volumes:
       - dolphinscheduler-zookeeper:/bitnami/zookeeper
+    ports:
+      - "2181:2181"

Review Comment:
   yes but i running local test application not found zookeeper and postgresql



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #13874: Postgresql upsert bug

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#discussion_r1195981468


##########
deploy/docker/docker-compose.yml:
##########
@@ -110,6 +108,8 @@ services:
     image: ${HUB}/dolphinscheduler-master:${TAG}
     profiles: ["all"]
     env_file: .env
+    ports:
+      - "5679:5679"

Review Comment:
   Please remove this.



##########
deploy/docker/docker-compose.yml:
##########
@@ -128,6 +128,8 @@ services:
     image: ${HUB}/dolphinscheduler-worker:${TAG}
     profiles: ["all"]
     env_file: .env
+    ports:
+      - "1235:1235"

Review Comment:
   Same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Postgresql upsert bug [dolphinscheduler]

Posted by "Alixxxxxxx (via GitHub)" <gi...@apache.org>.
Alixxxxxxx commented on PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#issuecomment-2323757035

   3.2.2 this bug is also in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Postgresql upsert bug [dolphinscheduler]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #13874: Postgresql upsert bug
URL: https://github.com/apache/dolphinscheduler/pull/13874


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #13874: Postgresql upsert bug

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #13874:
URL: https://github.com/apache/dolphinscheduler/pull/13874#discussion_r1196011869


##########
deploy/docker/docker-compose.yml:
##########
@@ -110,6 +108,8 @@ services:
     image: ${HUB}/dolphinscheduler-master:${TAG}
     profiles: ["all"]
     env_file: .env
+    ports:
+      - "5679:5679"

Review Comment:
   Sorry. My mistake. Reverted this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org